Skip to content

Fix End of Doc Bugs #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2025
Merged

Conversation

thecoolwinter
Copy link
Contributor

@thecoolwinter thecoolwinter commented Jun 26, 2025

Description

Fixes a few end-of-document bugs:

  • rectForOffset had an incorrect != instead of a < check for the end of the document.
  • mouseDown needed to be looser on finding content runs for the end of documents.

Adds test cases that would have caught both these bugs.

Related Issues

N/A

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

N/A

@thecoolwinter thecoolwinter merged commit 80fb884 into CodeEditApp:main Jun 26, 2025
2 checks passed
@thecoolwinter thecoolwinter deleted the fix/end-of-doc-bug branch June 26, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant