Skip to content

Issue #327: VolunteerHistory and Donations show most recent 3 #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 1, 2021

Conversation

dcstlouis
Copy link
Collaborator

@dcstlouis dcstlouis commented May 30, 2021

  • Donations data: should be ordered by most recent; change "Top 3" to "Most recent 3"
  • Volunteer history: should also be showing most recent 3 (not unique 3); change the "Top 3" to "Most recent 3"
  • Clicking on shelterluv link should open in new window (this was already done)

@dcstlouis dcstlouis requested a review from urirot May 30, 2021 21:31
@dcstlouis dcstlouis linked an issue May 30, 2021 that may be closed by this pull request
@dcstlouis dcstlouis requested a review from c-simpson May 30, 2021 22:55
@c-simpson
Copy link
Collaborator

@dcstlouis On contact TT (840), the dates in the Volunteer History list alternate every 1/2 second or so between 'Unknown' and 'Invalid date', so the Assignments list bounces right and left.

Same contact, SL link gets a 404 - are we using the right ID?

@kfettich
Copy link
Collaborator

kfettich commented May 31, 2021 via email

@dcstlouis
Copy link
Collaborator Author

@c-simpson I pushed a change that filters out all shifts with "invalid date", which should resolve the issue you were seeing.

Regarding the SL links: I'm not sure where the short IDs are coming from. The long IDs are from the SL API.

Copy link
Collaborator

@c-simpson c-simpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@c-simpson c-simpson merged commit 5baf060 into master Jun 1, 2021
@c-simpson c-simpson linked an issue Jun 1, 2021 that may be closed by this pull request
@c-simpson c-simpson deleted the 327/360-view-enhancements branch October 12, 2021 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

360 view: Dateutil parse error 360 View enhancements
3 participants