SAN-3947 - Set file size limits #1561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Myztiq
commented
Apr 22, 2016
•
Myztiq
commented
- Added logic to handle file too large errors
- @thejsj
- Reviewer 2
|
The latest push to PR-1561 is running on SAN-3947-file-size-limits-runnable-angular |
|
So the api is going to attempt to fetch the file, but then return an error? |
|
@Nathan219 Check this pr: CodeNow/api#1484 |
| @@ -9,6 +9,11 @@ | |||
| ) | |||
| p.p We're Sorry, but your file is in another castle… and that castle just blew up! 😱 | |||
|
|
|||
| .blank-panel( | |||
| ng-if = "!loading && hasError === 'tooLarge'" | |||
| ) | |||
There was a problem hiding this comment.
Would it be better to reuse the existing .blank-panel element and replace the text?
There was a problem hiding this comment.
If we did that'd result in having 3 ng-if's because we only want blank-panel to show if there is an error
There was a problem hiding this comment.
But it's a matter of preference, would you prefer I did that? @runnabro
There was a problem hiding this comment.
I was thinking that !loading && hasError might cover it. I just thought it would be simpler. Do what you think is simpler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.