Skip to content

Cannot start CodeTogether due to Proposed API #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lokimon opened this issue Apr 15, 2022 · 7 comments
Closed

Cannot start CodeTogether due to Proposed API #366

lokimon opened this issue Apr 15, 2022 · 7 comments
Labels
bug Something isn't working vscode VS-code side issue
Milestone

Comments

@lokimon
Copy link

lokimon commented Apr 15, 2022

Describe the bug
I am in an endless loop with a dialog box that pops up when starting Visual Studio Code.
Trying to install CodeTogether v2022.1.4

CodeTogether requires access to VS Code Proposed APIs to provide Terminal sharing, quick open for files, search in workspace and more. Enabling access allows CodeTogether to use these services for a richer experience. Would you like to enable now?

I click Enable and then Reload, and it pops up again.

Looking at developer tools I see this.

log.ts:319 CRITI Extension 'genuitecllc.codetogether' wants API proposal 'terminalLocation' but that proposal DOES NOT EXIST. Likely, the proposal has been finalized (check 'vscode.d.ts') or was abandoned.
log.ts:319 CRITI Extension 'genuitecllc.codetogether CANNOT USE these API proposals 'fileSearchProvider, findTextInFiles, terminalDataWriteEvent, terminalDimensions, terminalNameChangeEvent, testObserver, textSearchProvider'. You MUST start in extension development mode or use the --enable-proposed-api command line flag

To Reproduce
Steps to reproduce the behavior:

  1. Install CodeTogether Extension
  2. Click Dialog Box Enable
  3. Reload
  4. See error

Expected behavior
The dialog box should stop popping up.

Screenshots

CodeTogether Host

  • IDE: VSCode
  • IDE Version 1.66.2
  • OS: Ubuntu
  • OS Version: 21.10
@lokimon lokimon added bug Something isn't working unreviewed Pending review by development team labels Apr 15, 2022
@lokimon
Copy link
Author

lokimon commented Apr 15, 2022

It started working.

@lokimon lokimon closed this as completed Apr 15, 2022
@toddewilliams
Copy link
Contributor

@lokimon We haven't observed this behavior in a native installation, but we've seen this when running VS Code in certain containers, such as code-server, from time to time, and they're to resolve a recent re-emergence of that issue on their platform here.

Are you running VS Code natively on Ubuntu, or through a solution like code-server, coder.com, OpenVSCode Server, or some other VS Code delivery solution?

@toddewilliams
Copy link
Contributor

Ah, I see it's working for you now. I'll leave my comment in case it affects others, but I'm pleased everything is good now. Please let us know if you run into any other issues.

@toddewilliams toddewilliams removed the unreviewed Pending review by development team label Apr 15, 2022
@lokimon
Copy link
Author

lokimon commented Apr 22, 2022

I installed ubuntu 22.04 so I had to reinstall VSC and extensions.
I am getting this error again, but this time it's not going away.

I am running VS Code natively on Ubuntu. (I downloaded the deb and apt installed it).

I am still seeing this in the logs

log.ts:319 CRITI Extension 'genuitecllc.codetogether' wants API proposal 'terminalLocation' but that proposal DOES NOT EXIST. Likely, the proposal has been finalized (check 'vscode.d.ts') or was abandoned.
log.ts:319 CRITI Extension 'genuitecllc.codetogether CANNOT USE these API proposals 'fileSearchProvider, findTextInFiles, terminalDataWriteEvent, terminalDimensions, terminalNameChangeEvent, testObserver, textSearchProvider'. You MUST start in extension development mode or use the --enable-proposed-api command line flag

It's an endless cycle of Enable reload Enable reload.

@lokimon lokimon reopened this Apr 22, 2022
@toddewilliams
Copy link
Contributor

@lokimon this is interesting because the first error says that termainlLocation doesn't exist:

log.ts:319 CRITI Extension 'genuitecllc.codetogether' wants API proposal 'terminalLocation' but that proposal DOES NOT EXIST. Likely, the proposal has been finalized (check 'vscode.d.ts') or was abandoned.

Can you tell us what version of VSCode you've installed? It appears that this proposed API may have changed, in which case we'll need an update for that.

The second error is odd as it seems to indicate that the usual programmatic way to gain access to these APIs may have also changed. However, it does suggest a command line workaround:

You MUST start in extension development mode or use the --enable-proposed-api command line flag

Can you try restarting and using the --enable-proposed-api flag? The documentation for that flag is here and the extension id is "genuitecllc.codetogether"

@lokimon
Copy link
Author

lokimon commented Apr 22, 2022

I am running VSCode 1.66.2 which is latest.

code --enable-proposed-api=genuitecllc.codetogether

didn't seem to help

@wgalanciak wgalanciak added the vscode VS-code side issue label Apr 25, 2022
@wgalanciak
Copy link
Contributor

Hi @lokimon, to enable all services the full restart of VS Code is required. After clicking Enable Now, you should see a notification like this:

Exit and restart VS Code now to finish enabling all CodeTogether services.

If you see another one, which has a Reload action, then it means that you already have enabled the proposed API (argv.json is modified). We are going to investigate why it could lead to an endless Enable -> Reload cycle.

To confim the enablement in argv.json, you can run the Preferences: Configure Runtime Arguments command and check if genuitecllc.codetogether is added to the enable-proposed-api entry, for example it may look like this:

"enable-proposed-api": [
    "genuitecllc.codetogether"
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working vscode VS-code side issue
Projects
None yet
Development

No branches or pull requests

3 participants