Adding configurable staging repository description#63
Closed
akomakom wants to merge 6 commits intoCodearte:masterfrom
Closed
Adding configurable staging repository description#63akomakom wants to merge 6 commits intoCodearte:masterfrom
akomakom wants to merge 6 commits intoCodearte:masterfrom
Conversation
Author
|
Test failures appear to be environment-related, not up to me to fix. |
szpak
force-pushed
the
add-repository-description-setter
branch
from
79ecfbb to
3247e1b
Compare
Member
Member
|
Btw, add your email address you used in the commit to your GitHub account to be listed on the contributors page. |
szpak
force-pushed
the
add-repository-description-setter
branch
from
9b29ac5 to
b8c7321
Compare
Author
|
@szpak thanks for bringing this to my attention, I had user.email set all wrong on my 200 random work/non-work related repositories. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
my company relies on staging repository description for various cleanup jobs, so blindly setting them to "Automatically released/promoted with gradle-nexus-staging-plugin!" isn't always ideal.
I didn't add any tests because I couldn't figure out how to test this with wiremock - the best I could do was verify that the RepositoryCloser instance had the right description set in its field (which seemed kind of weak), so I didn't include that in this PR. Suggestions are welcome.