Symfony 6 support #157
Merged
Symfony 6 support #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
TavoNiievez
requested changes
May 10, 2022
TavoNiievez
approved these changes
May 10, 2022
There was a problem hiding this comment.
wow! looks pretty good now.
I'm going to merge it when I update the test project and have a successful run, but for now it has my thumbs up.
Thank you!
|
Please tell when you want to make a new release? |
|
@TavoNiievez We can release it as 3.1.0, right? |
|
@Naktibalda no, form assertions and test project still need to be adapted |
|
@semaz module-symfony 3.1 was released with support for Symfony 6.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced the authorization
guardlogic with aauthenticator, because this is the recommended authentication type in the new symfony (https://symfony.com/doc/current/security/custom_authenticator.html).Also changed methods
amLoggedInAsandgetCurrentSession.Can you review it and test it?