OSC logo conflict

[stax76]

Proposed solution which is not perfect but good enough:

Provide 2 new conf options:

show-command
Command executed before show.
Users can set this to:
script-message osc-visibility never

hide-command
Command executed after hide.
Users can set this to:
script-message osc-visibility auto

More info:
mpv-player/mpv#10201

[CogentRedTester]

How about I store the browser open status in the shared_script_properties property? Then you can activate things using conditional auto-profiles:

[file-browser]
profile-cond=shared_script_properties["file_browser-open"] == "yes"
profile-restore=copy-equal
script-opts-append=osc-visibility=never

This would just be easier than adding extra commands and options.

[CogentRedTester]

I just checked and shared_script_properties was added in mpv v0.31, which is the earliest version I support, so that would be a pretty neat solution.

[stax76]

I didn't really know about shared-script-properties and profiles is something I've never used. I'll take a look, thanks!

[stax76]

I think it would be ideal if things would work without every user having to search for a solution.

Maybe determine if a logo issue is possible by checking:

• osc-visibility is always or auto
• playlist-pos is -1
• how many lines has the menu string and how many characters has the longest line
• Font size

If a logo issue is possible, hide and restore the OSC.

[stax76]

Maybe it would be totally fine to always hide and restore the osc when the logo is visible (playlist-pos is -1), because the moment a user shows the menu, he is interested in the menu and not in the logo, simple and good solution.

[CogentRedTester]

It's true that I could automatically hide the OSC from within the script, and it might add a little extra functionality over using the auto-profiles. But, that would require me to implement and maintain support for the enabling/disabling logic (when to enable/disable, what to do if the user changes the settings, etc), which puts an extra burden on me for generally pretty insignificant improvements.

On the other hand, leaving it up to the user's auto-profiles gives them full control over what conditions are required (and I don't have to maintain anything). In addition, it allows for setting any arbitrary option using the profile rather than just being limited to the OSC visibility. What you suggested about hiding the OSC only when playlist-pos is -1 can be done as an additional condition as well.

So what I'm thinking is: save the file_browser-open field in shared_script_properties and add a section to the README saying it is there and giving the example profile I specified above.

What do you think?

[CogentRedTester]

This is the example I'd give, seems to work quite well:

[hide-logo]
profile-cond=shared_script_properties["file_browser-open"] == "yes" and idle_active
profile-restore=copy-equal
script-opts-append=osc-visibility=never

Edit: changed playlist_pos == -1 to idle_active since this the property that the OSC uses to decide whether or not to display the logo

[stax76]

If it works, and you document it, then it might indeed be a great solution.

[CogentRedTester]

I have pushed support for the feature. Please test it out and let me know what you think.

[stax76]

It works, with adjustment in mpv.net too, thanks!