Merged
Conversation
|
Thanks for opening this pull request! Things that will help get your PR across the finish line:
|
JaumePujantell
force-pushed
the
private/jaume/comment-width-test
branch
from
370b5f5 to
72654ec
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
JaumePujantell
force-pushed
the
private/jaume/comment-width-test
branch
from
72654ec to
3613dc6
Compare
caolanm
force-pushed
the
private/jaume/comment-width-test
branch
from
3613dc6 to
1d8eae2
Compare
vmiklos
approved these changes
Apr 2, 2026
Contributor
vmiklos
left a comment
vmiklos
left a comment
There was a problem hiding this comment.
Looks OK, please rebase & resolve conflicts. Thanks.
| // Add several nested replies to create a deep thread | ||
| var replyCount = 5; | ||
| for (var i = 1; i <= replyCount; i++) { | ||
| cy.cGet('#comment-annotation-menu-' + i).click({ force: true }); |
Contributor
There was a problem hiding this comment.
Nit: if this menu button is not visible because the screen is too small, then it would be better to use cy.viewport() instead of this force-click, which is always a bit of a code smell.
| cy.cGet('#annotation-content-area-1').should('contain', 'some text'); | ||
|
|
||
| // Add several nested replies to create a deep thread | ||
| var replyCount = 5; |
Contributor
There was a problem hiding this comment.
Nit: prefer let/const instead of 'var'.
JaumePujantell
force-pushed
the
private/jaume/comment-width-test
branch
from
1d8eae2 to
3a425d4
Compare
This is a test for commit 5ff7f51 (browser: do not let comments get too slim). Signed-off-by: Jaume Pujantell <jaume.pujantell@collabora.com> Change-Id: I5ff0e58230d2753ee6ec191d5c10e160c5adc72d
JaumePujantell
force-pushed
the
private/jaume/comment-width-test
branch
from
3a425d4 to
81dc90b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a test for commit 5ff7f51
(browser: do not let comments get too slim).
Signed-off-by: Jaume Pujantell jaume.pujantell@collabora.com
Change-Id: I5ff0e58230d2753ee6ec191d5c10e160c5adc72d