Conversation
- Add pnpm overrides for undici and undici-types (^7.28.0) so all transitive copies resolve to the patched release and Dependabot stops conflating undici-types@7.24.6 with vulnerable undici. - Fix getChatDayKey to use 1-based calendar months and align ChatPanel jump-to-date with the corrected day-key format. - Harden MeshtasticMqttClientProxyBridge configured-path writeToRadio with try/catch and add regression test for rejected writes. - Extract stripControlCharacters for silent OS notification text; document that App.tsx owns typed Web Audio for hidden-window alerts. - Relax Windows packaging contract tests to derive readable-stream patch version from the lockfile and accept any @electron/asar 4.x override.
1 task
rinchen
added a commit
that referenced
this pull request
Jun 19, 2026
- Empty string and printable-only strings pass through unchanged. - Boundary controls NUL (0x00), US (0x1F), and DEL (0x7F). - Multiple control characters stripped in one string. Addresses review feedback on regex /[\x00-\x1F\x7F]/g coverage from #553.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
undiciandundici-types(^7.28.0) so all transitive copies resolve to the patched release and Dependabot stops conflatingundici-types@7.24.6with vulnerableundici.getChatDayKeyto use 1-based calendar months and alignChatPaneljump-to-date with the corrected day-key format.MeshtasticMqttClientProxyBridgeconfigured-pathwriteToRadiowith try/catch and add regression test for rejected writes.stripControlCharactersfor silent OS notification text; document thatApp.tsxowns typed Web Audio for hidden-window alerts.@electron/asar4.x override.Test plan
pnpm run typecheckpnpm run lintpnpm run test:run(352 files / 3102 tests)