Skip to content

fix: device email editable#2321

Merged
PiTrem merged 2 commits intomainfrom
fix-device-email-editable
Feb 18, 2025
Merged

fix: device email editable#2321
PiTrem merged 2 commits intomainfrom
fix-device-email-editable

Conversation

@headri
Copy link
Contributor

@headri headri commented Feb 7, 2025

No description provided.

@headri headri requested review from JanCBrammer and PiTrem February 7, 2025 14:37
@headri headri force-pushed the fix-device-email-editable branch from 320d006 to 63dd850 Compare February 7, 2025 15:13
@github-actions
Copy link

github-actions bot commented Feb 7, 2025

LCOV of commit 63dd850 during Continuous Integration #4419

Summary coverage rate:
  lines......: 67.7% (15004 of 22176 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@headri headri marked this pull request as ready for review February 7, 2025 15:34
@PiTrem PiTrem changed the title Fix device email editable fix: device email editable Feb 10, 2025
@headri headri force-pushed the fix-device-email-editable branch from 63dd850 to 8ff8fee Compare February 11, 2025 09:54
@github-actions
Copy link

LCOV of commit 8ff8fee during Continuous Integration #4437

Summary coverage rate:
  lines......: 67.7% (15005 of 22177 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@headri headri requested a review from PiTrem February 11, 2025 10:17
@PiTrem PiTrem merged commit 791a46a into main Feb 18, 2025
3 checks passed
beque pushed a commit to megorei/chemotion_ELN that referenced this pull request Mar 4, 2025
admin can update a device's email

NB: email not uniq => mail-datacollector  device resolution
beque pushed a commit to megorei/chemotion_ELN that referenced this pull request Mar 5, 2025
admin can update a device's email

NB: email not uniq => mail-datacollector  device resolution
@PiTrem PiTrem added this to the v2.0.0 - Fixes & Chores milestone Mar 21, 2025
PiTrem added a commit that referenced this pull request Apr 1, 2025
…nvelopes (#2427)

recipient defined by cc were not properly reset with processing the next envelope in the queue

 - ensure the correspondence array is reset after processing each envelope in the mail-collector process.

- update mailcollector_spec.rb tests with new envelope scenarios, including handling known and unknown recipients in the to and cc fields.

- add a factory for Net::IMAP envelope objects to support more comprehensive tests


refs: #2321
alizaib1217 pushed a commit that referenced this pull request Apr 29, 2025
…nvelopes (#2427)

recipient defined by cc were not properly reset with processing the next envelope in the queue

 - ensure the correspondence array is reset after processing each envelope in the mail-collector process.

- update mailcollector_spec.rb tests with new envelope scenarios, including handling known and unknown recipients in the to and cc fields.

- add a factory for Net::IMAP envelope objects to support more comprehensive tests


refs: #2321
haditariq pushed a commit that referenced this pull request Apr 30, 2025
…nvelopes (#2427)

recipient defined by cc were not properly reset with processing the next envelope in the queue

 - ensure the correspondence array is reset after processing each envelope in the mail-collector process.

- update mailcollector_spec.rb tests with new envelope scenarios, including handling known and unknown recipients in the to and cc fields.

- add a factory for Net::IMAP envelope objects to support more comprehensive tests


refs: #2321
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

device email not editable as admin

2 participants