Skip to content

Add a markdown image preview for the node help menu. #4417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add a markdown image preview for the node help menu. #4417

wants to merge 3 commits into from
+233 −1

Conversation

comfyui-wiki
Copy link
Contributor

@comfyui-wiki comfyui-wiki commented Jul 10, 2025 •
edited
Loading

When updating the node docs, I found sometimes it's hard to preview the image, so I made this PR.
The code was written by Claude. I'm not good at development.

Screen.Recording.2025-07-10.at.23.48.49.mp4

┆Issue is synchronized with this Notion page by Unito

@comfyui-wiki comfyui-wiki marked this pull request as ready for review July 10, 2025 15:57
@comfyui-wiki comfyui-wiki requested a review from a team as a code owner July 10, 2025 15:57
christian-byrne
christian-byrne reviewed Jul 19, 2025
View reviewed changes
Copy link
Contributor

@christian-byrne christian-byrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move it into a new component that wraps ResultGallery? We also most likely don't need to use ResultGallery and can just use Galleria

@comfyui-wiki
refactor: extract markdown image gallery to separate component
11f3130 
- Create new MarkdownImageGallery component using PrimeVue Galleria directly
- Remove dependency on ResultGallery and ResultItemImpl
- Simplify image data structure with simple ImageItem interface
- Improve separation of concerns and maintainability
- Address review feedback to use dedicated component wrapper
@comfyui-wiki
Remove extra line breaks and clean up the code
1b597e7
@github-actions GitHub Actions
Copy link

⚠️ Warnings

⚠️ Warning: E2E Test Coverage Missing

If this PR modifies behavior that can be covered by browser-based E2E tests, those tests are required. PRs lacking applicable test coverage may not be reviewed until added. Please add or update browser tests to ensure code quality and prevent regressions.

@comfyui-wiki
Copy link
Contributor Author

Updated now. I think I gradually know how the FE works through these PRs, even though most of the code was done by Claude. Maybe I can start to try to use Vue to create some simple projects someday.

@christian-byrne
Copy link
Contributor

@benceruleanlu Could you handle doing all reviews for node help menu features/fixes?

@benceruleanlu
Copy link
Collaborator

@benceruleanlu Could you handle doing all reviews for node help menu features/fixes?

Sure, I'll take a look

Should I add myself to CODEOWNERS?

@benceruleanlu
Copy link
Collaborator

@claude I remember we have similar functionality for the output sidebar tab, where users can click on images to expand fully, similar to what we have here.

Do you think we can reuse the code here as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-byrne christian-byrne christian-byrne left review comments

@benceruleanlu benceruleanlu Awaiting requested review from benceruleanlu

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@comfyui-wiki @christian-byrne @benceruleanlu