Skip to content

Fix i18n workaround breaks node configure & subgraphs #4481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix i18n workaround breaks node configure & subgraphs #4481

wants to merge 2 commits into from

Conversation

webfiltered
Copy link
Contributor

@webfiltered webfiltered commented Jul 20, 2025 •
edited
Loading

Current

A stack of workarounds over time for i18n (and other fixes) resulted in a monkey patch in frontend that was:

  • Reading the current inputs of an existing node on the graph
  • (Good) Applying i18n to the new node configure data, if the input existed
  • (Bad) If not, adding inputs to the configure data as-is (the original, unserialised input objects)
    • Node inputs can not be removed by using configure

Proposed

  • Copy only the i18n values from the node into the configure data
  • Do not replace the inputs / outputs properties of the configure data
  • Do not pass existing input / output objects to the parent configure method
  • Removes need for extensions to workaround this peculiar behaviour
  • Drastically simplifies code

Issues

Any extensions that worked around the former behaviour may now be reliant on it. This should be verified before merging.

@webfiltered
Fix i18n workaround breaks node configure & subgraphs
2c72f5d 
- Copy *only* the i18n values from the node into the configure data
- Do not replace the inputs / outputs properties of the configure data
- Do not pass existing input / output objects to the parent `configure` method
- Removes need for extensions to workaround this peculiar behaviour
- Drastically simplifies code
@webfiltered webfiltered requested a review from a team as a code owner July 20, 2025 08:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 20, 2025 •
edited
Loading

⚠️ Warnings

⚠️ Warning: E2E Test Coverage Missing

If this PR modifies behavior that can be covered by browser-based E2E tests, those tests are required. PRs lacking applicable test coverage may not be reviewed until added. Please add or update browser tests to ensure code quality and prevent regressions.

⚠️ Warning: Visual Documentation Missing

If this PR changes user-facing behavior, visual proof (screen recording or screenshot) is required. PRs without applicable visual documentation may not be reviewed until provided.
You can add it by:

  • GitHub: Drag & drop media directly into the PR description

  • YouTube: Include a link to a short demo

webfiltered added a commit to Comfy-Org/litegraph.js that referenced this pull request Jul 20, 2025
@webfiltered
Add workaround for incorrect downstream patch
25cff7e 
- See Comfy-Org/ComfyUI_frontend#4481
This was referenced Jul 20, 2025
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@webfiltered