[fix] Handle missing _listenerController.abort when loading workflows #1134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rkflows - Add proper type checking before calling abort() on _listenerController - Fixes TypeError when loading workflows with promoted widgets - Input slots from deserialization don't have AbortController instances Fixes #1130
webfiltered
reviewed
Jul 18, 2025
|
It's described in the linked issue (#1130). |
|
Try loading this workflow on HEAD of litegraph.js master: |
|
But what is causing it? That is very clearly not how it is typed. So the PR is patching a symptom, but we'd still have completely invalid state. We'd just be ignoring it much more effectively. Probably quite easy to trace with a breakpoint on uncaught. |
|
Can you investigate? |
christian-byrne
added a commit
that referenced
this pull request
Jul 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1130
Description
When loading workflows with promoted widgets, a TypeError occurs because
_listenerControlleris not properly initialized on deserialized input slots.Changes
abort()on_listenerController#addSubgraphInputListeners,configure, andonRemovedTesting