Skip to content

Aspire-13.1 #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aaronpowell wants to merge 8 commits into from
Closed

Aspire-13.1 #1056

aaronpowell wants to merge 8 commits into from

Conversation

@aaronpowell
Copy link
Member

@aaronpowell aaronpowell commented Dec 11, 2025

  • Updated multiple test files to replace calls to GetEnvironmentVariableValuesAsync() with GetEnvironmentVariablesAsync().
  • Replaced calls to GetArgumentValuesAsync() with GetArgumentListAsync() in various test cases.
  • Introduced new utility methods in the CommunityToolkit.Aspire.Testing namespace for better argument and environment variable handling.

Closes #<ISSUE_NUMBER>

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • New integration
    • Docs are written
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

Other information

@aaronpowell
Bumping to the current 13.1 preview for initial testing work
e887e25
@aaronpowell
Updating redis types due to obsoleting
ffb97b9
@aaronpowell
Refactor tests to use new environment variable and argument retrieval…
7cd5d0e 
… methods

- Updated multiple test files to replace calls to GetEnvironmentVariableValuesAsync() with GetEnvironmentVariablesAsync().
- Replaced calls to GetArgumentValuesAsync() with GetArgumentListAsync() in various test cases.
- Introduced new utility methods in the CommunityToolkit.Aspire.Testing namespace for better argument and environment variable handling.
@afscrome afscrome mentioned this pull request Dec 11, 2025
Open
@aaronpowell aaronpowell mentioned this pull request Dec 11, 2025
Draft
10 tasks
aaronpowell and others added 5 commits December 14, 2025 22:48
@aaronpowell
Updating to lastest 13.1 build
05a0c91
@aaronpowell
Evaluating the annotations directly
28221bc
@aaronpowell
Changing how to handle env vars in keycloak tests
9757fa6
@aaronpowell
Missed a test
91718ea
@FullStackChef
Switch to Azure Redis Enterprise for infra and tests
ed6333d 
Updated infrastructure and test code to use Azure Redis Enterprise (Microsoft.Cache/redisEnterprise) instead of the legacy Azure Redis Cache. Refactored connection string handling and key retrieval to use RedisEnterpriseCluster and RedisEnterpriseDatabase resources. Updated Bicep templates and test assertions accordingly. Removed obsolete test for non-SSL port, as Redis Enterprise always requires TLS. This modernizes the codebase to align with current Azure recommendations.
@github-actions github-actions bot added the Stale label Dec 21, 2025
@github-actions github-actions bot closed this Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martinjt martinjt Awaiting requested review from martinjt martinjt will be requested when the pull request is marked ready for review martinjt is a code owner

@Harold-Morgan Harold-Morgan Awaiting requested review from Harold-Morgan Harold-Morgan will be requested when the pull request is marked ready for review Harold-Morgan is a code owner

@Alirexaa Alirexaa Awaiting requested review from Alirexaa Alirexaa will be requested when the pull request is marked ready for review Alirexaa is a code owner

@shiranshalom shiranshalom Awaiting requested review from shiranshalom shiranshalom will be requested when the pull request is marked ready for review shiranshalom is a code owner

@FullStackChef FullStackChef Awaiting requested review from FullStackChef FullStackChef will be requested when the pull request is marked ready for review FullStackChef is a code owner

@WhitWaldo WhitWaldo Awaiting requested review from WhitWaldo WhitWaldo will be requested when the pull request is marked ready for review WhitWaldo is a code owner

@paule96 paule96 Awaiting requested review from paule96 paule96 will be requested when the pull request is marked ready for review paule96 is a code owner

@esskar esskar Awaiting requested review from esskar esskar will be requested when the pull request is marked ready for review esskar is a code owner

@MichielBrys MichielBrys Awaiting requested review from MichielBrys MichielBrys will be requested when the pull request is marked ready for review MichielBrys is a code owner

@ErikEJ ErikEJ Awaiting requested review from ErikEJ ErikEJ will be requested when the pull request is marked ready for review ErikEJ is a code owner

@jmezach jmezach Awaiting requested review from jmezach jmezach will be requested when the pull request is marked ready for review jmezach is a code owner

@tommasodotNET tommasodotNET Awaiting requested review from tommasodotNET tommasodotNET will be requested when the pull request is marked ready for review tommasodotNET is a code owner

@fboucher fboucher Awaiting requested review from fboucher fboucher will be requested when the pull request is marked ready for review fboucher is a code owner

@justinyoo justinyoo Awaiting requested review from justinyoo justinyoo will be requested when the pull request is marked ready for review justinyoo is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aaronpowell @FullStackChef