Set Image and Registry Seperately in Otel Collector #1070
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than fudge the registry into the image name, set the registry property explicitly.
For some context of why this matters to me - my org's build agents have locked down firewalls, and we have to rewrite public registries to internal mirrors - we do this by looking at the Registry property in a
BeforeStarthook - see more at https://youtu.be/u0iK6Bv5BZ0?si=AtJ_DmYCn1t0Mq5f&t=1124 .PR Checklist
Other information