(Marquee) When Behavior="Looping" and Direction is set to vertical, it causes “Layout cycle detected. Layout could not complete.”

[lgztx96]

Describe the bug

Labs-Windows/components/Marquee/src/Marquee.xaml

Line 9 in acda1c3

<Setter Property="VerticalAlignment" Value="Top" />

Labs-Windows/components/Marquee/src/Marquee.Events.cs

Line 62 in acda1c3

private void Container_SizeChanged(object sender, SizeChangedEventArgs e)

Labs-Windows/components/Marquee/src/Marquee.cs

Line 241 in acda1c3

_segment2.Visibility = IsLooping ? Visibility.Visible : Visibility.Collapsed;

Labs-Windows/components/Marquee/src/Marquee.cs

Line 211 in acda1c3

_segment2.Visibility = Visibility.Collapsed;

I noticed that the Marquee control crashes. After debugging, I believe the SizeChanged event causes the visibility of segment2 to change. Since the control’s default vertical alignment is set to Top, this triggers another SizeChanged event, resulting in an infinite loop.
Setting VerticalAlignment="Stretch" allows it to work correctly, but this is not a real solution.

In addition, I noticed that _marqueeContainer is repeatedly subscribing to the SizeChanged event.

Labs-Windows/components/Marquee/src/Marquee.cs

Line 69 in acda1c3

_marqueeContainer.SizeChanged += Container_SizeChanged;

Labs-Windows/components/Marquee/src/Marquee.Events.cs

Line 36 in acda1c3

_marqueeContainer.SizeChanged += Container_SizeChanged;

Steps to reproduce

<labs:Marquee
     Behavior="Looping"
     Content="Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua."
     Direction="Down"
     FontSize="18"
     RepeatBehavior="Forever"
     Speed="200" />


Just setting Behavior="Looping" is enough to trigger the crash.

Expected behavior

This shouldn't cause the program to crash.

Screenshots

Code Platform

• UWP
• WinAppSDK / WinUI 3
• Web Assembly (WASM)
• Android
• iOS
• MacOS
• Linux / GTK

Windows Build Number

• Windows 10 1809 (Build 17763)
• Windows 10 1903 (Build 18362)
• Windows 10 1909 (Build 18363)
• Windows 10 2004 (Build 19041)
• Windows 10 20H2 (Build 19042)
• Windows 10 21H1 (Build 19043)
• Windows 11 21H2 (Build 22000)
• Other (specify)

Other Windows Build number

No response

App minimum and target SDK version

• Windows 10, version 1809 (Build 17763)
• Windows 10, version 1903 (Build 18362)
• Windows 10, version 1909 (Build 18363)
• Windows 10, version 2004 (Build 19041)
• Other (specify)

Other SDK version

No response

Visual Studio Version

No response

Visual Studio Build Number

No response

Device form factor

No response

Additional context

No response

[Avid29]

Okay. I pretty heavily refactored the event flow of this behavior in #735. I'll take a look at if this still happens with those changes.