Add IProvideParentValues as required service for AppThemeResourceExtension #2460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/CommunityToolkit.Maui/Extensions/AppThemeResourceExtension.shared.cs:6
- The newly added required service 'IProvideParentValues' should have test coverage to ensure it is correctly provided and used.
[ContentProperty(nameof(Key)), RequireService([typeof(IServiceProvider), typeof(IProvideParentValues)])]
2 tasks
bijington
approved these changes
Jan 20, 2025
VladislavAntonyuk
added a commit
to matt-goldman/Maui-1
that referenced
this pull request
Dec 4, 2025
Ensures temporary directory used by the file picker is always removed after the file selection is made, regardless of success or failure. Also improves error handling when a view controller cannot be retrieved. Fixes CommunityToolkit#2460
TheCodeTraveler
added a commit
that referenced
this pull request
Jan 8, 2026
* Test file saver with export to service mode * Used correct constructor with asCopy set to true * Add temporary directory cleanup in file saving process * Fixes disposal of temporary file on iOS Ensures temporary directory used by the file picker is always removed after the file selection is made, regardless of success or failure. Also improves error handling when a view controller cannot be retrieved. Fixes #2460 * Fixes disposal of temporary directory on iOS Ensures temporary directory used by the file picker is correctly removed on iOS. Moves the directory removal to the completion handler of the view controller presentation, ensuring it's executed after the picker is dismissed. Handles exceptions during file removal by re-throwing them after attempting to remove the temporary directory. * Update src/CommunityToolkit.Maui.Core/Essentials/FileSaver/FileSaverImplementation.macios.cs Co-authored-by: Copilot <[email protected]> * Refactor temp file cleanup in FileSaver (macOS/iOS) Move temp file removal to finally block to ensure cleanup always occurs. Remove redundant cleanup from view controller presentation callback. * Apply suggestion from @Copilot Co-authored-by: Copilot <[email protected]> * Ensure resources are only created if UI is available, improve error message, ensure temp directory is deleted (not just temp file) * Move dispose to finally * fix naming * fix order * check for index * rework File/FolderPicker. Removed IDisposable, Added IsCancelled * Remove `ConfigureAwait(false)`, Implement CancellationToken, Implement `.WaitAsync()` * Remove invalid `MemberNotNull`s * Use `ExceptionDispatchInfo.Throw` to improve exception handling * Remove `ConfigureAwait(false)`, Use `WaitAsync()` * Remove invalid `MemberNotNull` attributes, Use `ExceptionDispatchInfo.Throw` * Use `FolderPickerException` --------- Co-authored-by: Vladislav Antonyuk <[email protected]> Co-authored-by: Brandon Minnick <[email protected]> Co-authored-by: Copilot <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
We forgot to add
IProvideParentValuesas a required service onAppThemeResourceExtension. Therefore it would break when used in release mode because it would be trimmed out and not available.Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PR