Skip to content

[Housekeeping] Add [SupportedOSPlatform] to AppBuilderExtensions #2488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheCodeTraveler merged 4 commits into from
Feb 3, 2025
Merged

[Housekeeping] Add [SupportedOSPlatform] to AppBuilderExtensions #2488

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8f47323
Update AppBuilderExtensions.shared.cs
TheCodeTraveler Feb 3, 2025
5454509
Update Android NavigationBar Minimum OS Support
TheCodeTraveler Feb 3, 2025
3db7819
Update all AppBuilderExtensions
TheCodeTraveler Feb 3, 2025
571b932
Merge branch 'main' into Add-`-SupportedOSPlatform]`-to-AppBuilderExt…
VladislavAntonyuk Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/CommunityToolkit.Maui.Core/AppBuilderExtensions.shared.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System.Diagnostics;
using System.Runtime.Versioning;
using CommunityToolkit.Maui.Core.Services;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Maui.LifecycleEvents;
Expand All @@ -9,6 +10,11 @@ namespace CommunityToolkit.Maui.Core;
/// <summary>
/// <see cref="MauiAppBuilder"/> Extensions
/// </summary>
[SupportedOSPlatform("iOS15.0")]
[SupportedOSPlatform("MacCatalyst15.0")]
[SupportedOSPlatform("Android21.0")]
[SupportedOSPlatform("Windows10.0.17763")]
[SupportedOSPlatform("Tizen6.5")]
public static class AppBuilderExtensions
{
/// <summary>
Expand Down
8 changes: 7 additions & 1 deletion ...i.Maps/AppHostBuilderExtensions.shared.cs → ...Toolkit.Maui.Maps/AppBuilderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,17 @@
using System.Diagnostics.CodeAnalysis;
using System.Runtime.Versioning;

namespace CommunityToolkit.Maui.Maps;

/// <summary>
/// Maps Extensions for <see cref="MauiAppBuilder"/>
/// </summary>
public static class AppHostBuilderExtensions
[SupportedOSPlatform("iOS15.0")]
[SupportedOSPlatform("MacCatalyst15.0")]
[SupportedOSPlatform("Android21.0")]
[SupportedOSPlatform("Windows10.0.17763")]
[SupportedOSPlatform("Tizen6.5")]
public static class AppBuilderExtensions
{
/// <summary>
/// Initializes the .NET MAUI Community Toolkit Maps Library
Expand Down
8 changes: 7 additions & 1 deletion src/CommunityToolkit.Maui.MediaElement/AppBuilderExtensions.shared.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,17 @@
using CommunityToolkit.Maui.Core.Handlers;
using System.Runtime.Versioning;
using CommunityToolkit.Maui.Core.Handlers;
using CommunityToolkit.Maui.Views;

namespace CommunityToolkit.Maui;

/// <summary>
/// This class contains MediaElement's <see cref="MauiAppBuilder"/> extensions.
/// </summary>
[SupportedOSPlatform("iOS15.0")]
[SupportedOSPlatform("MacCatalyst15.0")]
[SupportedOSPlatform("Android26.0")]
[SupportedOSPlatform("Windows10.0.17763")]
[SupportedOSPlatform("Tizen6.5")]
public static class AppBuilderExtensions
{
/// <summary>
Expand All @@ -21,7 +27,7 @@
});

#if ANDROID
builder.Services.AddSingleton<Media.Services.MediaControlsService>();

Check warning on line 30 in src/CommunityToolkit.Maui.MediaElement/AppBuilderExtensions.shared.cs

View workflow job for this annotation

GitHub Actions / Build Library (macos-15) 

This call site is reachable on: 'Android' 26.0 and later, 'iOS' 15.0 and later, 'maccatalyst' 15.0 and later, 'Tizen' 6.5 and later, 'Windows' 10.0.17763 and later. 'MediaControlsService' is only supported on: 'Android' 26.0 and later. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416)

Check warning on line 30 in src/CommunityToolkit.Maui.MediaElement/AppBuilderExtensions.shared.cs

View workflow job for this annotation

GitHub Actions / Build Library (macos-15) 

This call site is reachable on: 'Android' 26.0 and later, 'iOS' 15.0 and later, 'maccatalyst' 15.0 and later, 'Tizen' 6.5 and later, 'Windows' 10.0.17763 and later. 'MediaControlsService' is only supported on: 'Android' 26.0 and later. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416)
#endif
return builder;
}
Expand Down
11 changes: 10 additions & 1 deletion src/CommunityToolkit.Maui/AppBuilderExtensions.shared.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using CommunityToolkit.Maui.Core;
using System.Runtime.Versioning;
using CommunityToolkit.Maui.Core;
using CommunityToolkit.Maui.Core.Handlers;
using CommunityToolkit.Maui.PlatformConfiguration.AndroidSpecific;
using CommunityToolkit.Maui.Views;
Expand All @@ -8,6 +9,11 @@
/// <summary>
/// Extensions for MauiAppBuilder
/// </summary>
[SupportedOSPlatform("iOS15.0")]
[SupportedOSPlatform("MacCatalyst15.0")]
[SupportedOSPlatform("Android21.0")]
[SupportedOSPlatform("Windows10.0.17763")]
[SupportedOSPlatform("Tizen6.5")]
public static class AppBuilderExtensions
{
/// <summary>
Expand All @@ -34,7 +40,10 @@
});

Popup.RemapForControls();

#if ANDROID
NavigationBar.RemapForControls();

Check warning on line 45 in src/CommunityToolkit.Maui/AppBuilderExtensions.shared.cs

View workflow job for this annotation

GitHub Actions / Build Library (macos-15) 

This call site is reachable on: 'Android' 21.0 and later, 'iOS' 15.0 and later, 'maccatalyst' 15.0 and later, 'Tizen' 6.5 and later, 'Windows' 10.0.17763 and later. 'NavigationBar.RemapForControls()' is only supported on: 'Android' 23.0 and later. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416)
#endif
return builder;
}
}
2 changes: 1 addition & 1 deletion src/CommunityToolkit.Maui/PlatformConfiguration/AndroidSpecific/NavigationBar.android.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,9 @@

var color = GetColor(page).ToPlatform();

if (OperatingSystem.IsAndroidVersionAtLeast(21))
if (OperatingSystem.IsAndroidVersionAtLeast(23))
{
window.SetNavigationBarColor(color);

Check warning on line 98 in src/CommunityToolkit.Maui/PlatformConfiguration/AndroidSpecific/NavigationBar.android.cs

View workflow job for this annotation

GitHub Actions / Build Library (macos-15) 

This call site is reachable on: 'Android' 23.0 and later. 'Window.SetNavigationBarColor(Color)' is obsoleted on: 'Android' 35.0 and later. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1422)
}
else
{
Expand Down
2 changes: 1 addition & 1 deletion src/CommunityToolkit.Maui/PlatformConfiguration/AndroidSpecific/NavigationBar.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ namespace CommunityToolkit.Maui.PlatformConfiguration.AndroidSpecific;
/// <summary>
/// Provides platform-specific configuration properties for the Android navigation bar.
/// </summary>
[SupportedOSPlatform("Android21.0")]
[SupportedOSPlatform("Android23.0")]
public static partial class NavigationBar
{
/// <summary>
Expand Down
Loading