Skip to content

Conversation

@VladislavAntonyuk
Copy link
Collaborator

Description of Change

Linked Issues

  • Fixes #

PR Checklist

Additional information

Copilot AI review requested due to automatic review settings June 23, 2025 09:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the GitHub Actions workflow for publishing to NuGet by modifying the signing conditions and splitting the release process into separate jobs.

  • Updated the sign job condition to include non-pull_request events.
  • Introduced a new release-main job for branch pushes (non-PR, non-tag events) to publish signed packages.
  • Retained the existing release-nuget job for tag-based releases.

@bijington
Copy link
Contributor

Thanks @VladislavAntonyuk how do we go about testing this? Is it a case of merging and then seeing what happens?

@VladislavAntonyuk
Copy link
Collaborator Author

Thanks @VladislavAntonyuk how do we go about testing this? Is it a case of merging and then seeing what happens?

Yes, as it is only configured to the main branch and tags

@TheCodeTraveler TheCodeTraveler added the needs discussion Discuss it on the next Monthly standup label Jun 26, 2025
@VladislavAntonyuk VladislavAntonyuk changed the title Publish main to public nuget Publish main to github nuget Jul 3, 2025
@TheCodeTraveler TheCodeTraveler merged commit 0f0e8d3 into main Jul 3, 2025
8 checks passed
@TheCodeTraveler TheCodeTraveler deleted the publish-nuget branch July 3, 2025 19:53
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs discussion Discuss it on the next Monthly standup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants