Skip to content

Use NuGet package references to other components where possible #117

Closed
@Arlodotexe

Description

@Arlodotexe

Background

I may have been out of the loop while away, why do we have these two like this? This was needed for the extensions because we use them in the Test infrastructure (and maybe because of the Sample App). Are we using things from these in those places too?
Otherwise, a regular project reference should work? As it should get resolved locally as a project but as a NuGet reference when built for packaging.
We needed it for extensions, as to build Labs and use the sub-module elsewhere we needed the extensions as it's part of the tooling itself, but then swap within the Windows repo. If we don't use the Helpers/Primitives in the Sample App/Testing stuff, then we don't need the same approach.

Originally posted by @michael-hawker in #77 (comment)

This was one of the things we were unsure about, glad to clear that up 👍
Think I'll open a separate PR and clean them all up.

Originally posted by @Arlodotexe in #77 (comment)

Problem

In a Toolkit Component, we should be referencing the NuGet version of other components instead of referencing the csproj directly.

Metadata

Metadata

Assignees

No one assigned

    Labels

    dev loop ➰low difficultyA small or trivial change that isn't difficult to complete.

    Type

    No type

    Projects

    Status

    ✅ Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions