Refactor ObjectExtensions -> ObjectMarshal #3760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergio0694
added
introduce breaking changes 💥
improvements ✨
high-performance 🚂
ghost
added
the
|
Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
requested review from
michael-hawker,
azchohfi,
Kyaa-dost and
Rosuavio
Rosuavio
approved these changes
Feb 17, 2021
|
Hello @michael-hawker! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 2 hours 42 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
michael-hawker
approved these changes
Feb 17, 2021
michael-hawker
added
the
next preview ✈️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
All the
objecthelpers are exposed as extensions through theObjectExtensionsclass. These methods are all pretty dangerous and should only be used in very specific scenarios, but having them as extensions (and onobjecttoo) means they pop up in IntelliSense everywhere, as soon as a consumer references theMicrosoft.Toolkit.HighPerformancepackage. This is not ideal and could be confusing for consumers, or at least just make the IntelliSense window more crowded for no real benefit.What is the new behavior?
The
objectextensions have been moved to a static helper classObjectMarshal, and they're no longer extensions.PR Checklist
Please check if your PR fulfills the following requirements:
Pull Request has been submitted to the documentation repository instructions. Link:Sample in sample app has been added / updated (for bug fixes / features)Icon has been created (if new sample) following the Thumbnail Style Guide and templates