-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Added solution filter for .NET projects #3906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added solution filter for .NET projects #3906
Conversation
Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
@Sergio0694 I like this, but on linux and mac dont users only have access to vscode. I am not too familiar with the c# workflow from vscode, but I would like to know steps a user has to take to take advantage of this and what it looks like for them. |
@RosarioPulella I think that on other platforms there are still ways to leverage solution files, eg. I believe JetBrains Rider is capable of opening solution files, so users of that IDE would be able to use the solution filter. As for users with VS Code, I think those could just manually open the folder (not the solution), and then they'd able to compile the individual projects directly, though we could investigate VS Code support more in the future as well, sure 👍 For this PR specifically, my idea is that having a solution filter right now would at the very least make life much easier for existing VS users that are only interested in contributing to .NET projects (eg. I've been using this solution filter while working on #3873 because opening the entire solution every time was taking too long, and this has made my workflow much better), and it'd at the same time have the welcome "side effect" of also making things simpler for users on IDEs supporting solutions as well (like Rider, as mentioned before). But I didn't mean this PR on its own to make the Toolkit as a whole necessarily "cross platform friendly" 🙂 Thoughts? |
Thanks @Sergio0694, I think that shows the usefulness of this change. I was hoping there was some utility for VSCode users, but I see how this can help a subset of our contributors. I think if we really want to better support contributors from platforms other than windows we should look into improving a workflow using VSCode. Like maybe adding a |
Hello @RosarioPulella! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 4 hours 5 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
c3cdc38
to
8d8107f
Compare
8d8107f
to
4ee1c0e
Compare
b6a052d
to
1c8fd28
Compare
@Sergio0694 assume the Unit Tests can also be run without issue from the VS IDE? I like the idea of providing a As part of 7.1, we need to figure out how we manage the project from a repo/git perspective, so that'll be the big technical challenge we face next... 🙂 |
@michael-hawker Yup, you just get this smaller solution which loads super fast and only needs the .NET SDKs: All those .NET unit test projects build and run just fine, so you can fully test code from those projects from here 🙂
Yup, agreed that that could be helpful for devs on other platforms other than Windows wanting to contribute to the .NET projects in the WCT, absolutely! We could definitely open another PR to add a |
1c8fd28
to
509877e
Compare
PR Type
What kind of change does this PR introduce?
What is the current behavior?
There is no solution filter or solution available to only work on .NET-based projects. This has two issues:
What is the new behavior?
There is now a solution filter with just the .NET projects, which makes it super easy to only load up those projects to contribute to the Toolkit. The solution filter is much faster to load and makes it generally a better experience to work in this scenario 😄
PR Checklist
Please check if your PR fulfills the following requirements:
Pull Request has been submitted to the documentation repository instructions. Link:Sample in sample app has been added / updated (for bug fixes / features)Icon has been created (if new sample) following the Thumbnail Style Guide and templatesNew major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...