Skip to content

Fix most build warnings from the projects #4125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 16, 2021
Merged

Fix most build warnings from the projects #4125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b695a6d
Fix CS1591 warnings
Nirmal4G Mar 14, 2021
9724809
Fix ILT0010 warnings
Nirmal4G Mar 14, 2021
445b6cd
Fix SA1208, SA1210, SA1505 warnings
Nirmal4G Mar 14, 2021
f697af0
Update UnitTests' EditorConfig
Nirmal4G Jul 30, 2021
19c62a3
Fix CS8618 warnings
Nirmal4G Jul 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions UITests/UITests.Tests.Shared/Controls/GridSplitterTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,14 @@
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

using Microsoft.Windows.Apps.Test.Foundation;
using Microsoft.Windows.Apps.Test.Foundation.Controls;
using Windows.UI.Xaml.Tests.MUXControls.InteractionTests.Common;
using Windows.UI.Xaml.Tests.MUXControls.InteractionTests.Infra;
using System.Linq;
using System.Threading.Tasks;
using System;
using System.Collections.Generic;
using System.Dynamic;
using System;
using System.Linq;
using System.Threading.Tasks;

using Microsoft.Windows.Apps.Test.Foundation;
using Microsoft.Windows.Apps.Test.Foundation.Controls;

#if USING_TAEF
using WEX.Logging.Interop;
Expand All @@ -20,9 +19,11 @@
using Microsoft.VisualStudio.TestTools.UnitTesting;
#endif

using Windows.UI.Xaml.Tests.MUXControls.InteractionTests.Common;
using Windows.UI.Xaml.Tests.MUXControls.InteractionTests.Infra;

namespace UITests.Tests
{

[TestClass]
public class GridSplitterTest : UITestBase
{
Expand Down
6 changes: 3 additions & 3 deletions UITests/UITests.Tests.Shared/Controls/RangeSelectorTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
// See the LICENSE file in the project root for more information.

using Microsoft.Windows.Apps.Test.Foundation.Controls;
using Windows.UI.Xaml.Tests.MUXControls.InteractionTests.Common;
using Windows.UI.Xaml.Tests.MUXControls.InteractionTests.Infra;

#if USING_TAEF
using WEX.Logging.Interop;
Expand All @@ -14,9 +12,11 @@
using Microsoft.VisualStudio.TestTools.UnitTesting;
#endif

using Windows.UI.Xaml.Tests.MUXControls.InteractionTests.Common;
using Windows.UI.Xaml.Tests.MUXControls.InteractionTests.Infra;

namespace UITests.Tests
{

[TestClass]
public class RangeSelectorTest : UITestBase
{
Expand Down
2 changes: 1 addition & 1 deletion UITests/UITests.Tests.Shared/Controls/RichSuggestBoxTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

using Microsoft.Windows.Apps.Test.Automation;
using Microsoft.Windows.Apps.Test.Foundation;
using Microsoft.Windows.Apps.Test.Foundation.Controls;
using Windows.UI.Xaml.Tests.MUXControls.InteractionTests.Common;
using Windows.UI.Xaml.Tests.MUXControls.InteractionTests.Infra;
using Microsoft.Windows.Apps.Test.Automation;

#if USING_TAEF
using WEX.Logging.Interop;
Expand Down
5 changes: 3 additions & 2 deletions UITests/UITests.Tests.Shared/UITestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@
using System.IO;
using System.Linq;
using System.Reflection;
using Windows.UI.Xaml.Tests.MUXControls.InteractionTests.Common;
using Windows.UI.Xaml.Tests.MUXControls.InteractionTests.Infra;
using System.Threading.Tasks;

#if USING_TAEF
Expand All @@ -18,6 +16,9 @@
using Microsoft.VisualStudio.TestTools.UnitTesting;
#endif

using Windows.UI.Xaml.Tests.MUXControls.InteractionTests.Common;
using Windows.UI.Xaml.Tests.MUXControls.InteractionTests.Infra;

namespace UITests.Tests
{
public abstract class UITestBase
Expand Down
4 changes: 4 additions & 0 deletions UnitTests/UnitTests.HighPerformance.UWP/UnitTests.HighPerformance.UWP.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,10 @@
<PackageReference Include="System.Runtime.CompilerServices.Unsafe">
<Version>5.0.0</Version>
</PackageReference>
<!-- For warnings ILT0010, ILT0005, ILT0003 -->
<PackageReference Include="System.Xml.XPath.XmlDocument">
<Version>4.0.1</Version>
</PackageReference>
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\..\Microsoft.Toolkit.HighPerformance\Microsoft.Toolkit.HighPerformance.csproj">
Expand Down
4 changes: 2 additions & 2 deletions UnitTests/UnitTests.NetCore/Mvvm/Test_ObservablePropertyAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,15 +235,15 @@ public enum Animal
public partial class ModelWithValueProperty : ObservableObject
{
[ObservableProperty]
private string value;
private string? value;
}

public partial class ModelWithValuePropertyWithValidation : ObservableValidator
{
[ObservableProperty]
[Required]
[MinLength(5)]
private string value;
private string? value;
}
}
}
3 changes: 3 additions & 0 deletions UnitTests/UnitTests.Notifications.UWP/UnitTestApp.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ namespace UnitTests.Notifications.UWP
/// </summary>
public sealed partial class App : Application
{
/// <summary>
/// Initializes a new instance of the <see cref="App"/> class.
/// </summary>
public App()
{
InitializeComponent();
Expand Down
16 changes: 13 additions & 3 deletions UnitTests/UnitTests.Shared/.editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,17 @@
[*.{cs,vb}]

# SA1601: Partial elements should be documented
# Analyzer Configurations for Unit Test sources

# C# Source Files
[*.cs]

# A C# partial element is missing a documentation header.
dotnet_diagnostic.SA1601.severity = none

# The Parameter has no matching param tag in the XML comment.
dotnet_diagnostic.CS1573.severity = none

# Missing XML comment for publicly visible type or member.
dotnet_diagnostic.CS1591.severity = none
dotnet_diagnostic.CS1712.severity = none

# The Type parameter has no matching typeparam tag in the XML comment.
dotnet_diagnostic.CS1712.severity = none