Skip to content

Add design metadata for RichSuggestBox #4200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 31, 2021

Conversation

huynhsontung
Copy link
Contributor

@huynhsontung huynhsontung commented Aug 28, 2021

Adding design metadata for RichSuggestBox.

PR Type

What kind of change does this PR introduce?

  • Other... Improve Visual Studio design tool integration

What is the current behavior?

No metadata for RichSuggestBox control.

What is the new behavior?

Design metadata is added for RichSuggestBox

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Aug 28, 2021

Thanks huynhsontung for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker, azchohfi and Rosuavio August 28, 2021 08:24
@michael-hawker
Copy link
Member

Thanks @huynhsontung! @Nirmal4G this look good to you?

Copy link
Contributor

@Nirmal4G Nirmal4G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍. I thought of filling the gaps with source generators but hey… this is not so bad in the meantime. I'll also add basic support for media controls.

Thanks so much for this.🚀

@michael-hawker michael-hawker merged commit eff2ee5 into CommunityToolkit:main Aug 31, 2021
@huynhsontung huynhsontung deleted the rsb-metadata branch September 1, 2021 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants