Skip to content

Improving ComboBoxColumn behavior to prevent triple click behavior #4209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

bolyb
Copy link
Contributor

@bolyb bolyb commented Aug 31, 2021

Fixes #3161

This implementation fixes the need to click a ComboBox in a DataGridComboBoxColumn 3 times before the DropDown opens.

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

The current behavior is that in order to expand a ComboBox DropDown, the cell must first be clicked once to be highlighted, then the ComboBox must be clicked twice more before the DropDown expands.

For more information, see: https://github.com/CommunityToolkit/WindowsCommunityToolkit/issues/3161

What is the new behavior?

The new behavior is that after the ComboBox is clicked once to be highlighted, the next click expands the DropDown.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Aug 31, 2021

Thanks bolyb for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker, azchohfi and Rosuavio August 31, 2021 20:57
@ghost ghost added bug 🐛 An unexpected issue that highlights incorrect behavior DataGrid 🔠 Issues on DataGrid control labels Aug 31, 2021
@michael-hawker michael-hawker added this to the 7.1 milestone Aug 31, 2021
@XAML-Knight
Copy link
Contributor

Hi @bolyb, it appears you're trying to merge this code in from the main/master branch of your forked repo.

Please be aware of the rules & stipulations of submitting code into the Toolkit repo:

image

@bolyb
Copy link
Contributor Author

bolyb commented Sep 2, 2021

Thank you for pointing me in the right direction on the correct procedures for this repo, I will close this pull request and create a new one from an appropriately named feature branch of my forked repo.

@bolyb bolyb closed this Sep 2, 2021
@michael-hawker michael-hawker removed this from the 7.1 milestone Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior DataGrid 🔠 Issues on DataGrid control
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataGrid ComboBoxColumn must be clicked 3 times for each ComboBox to expand
3 participants