Skip to content

Update to WinUI 2.7 #4256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2021

Conversation

michael-hawker
Copy link
Member

Fixes

WinUI 2.7 just shipped yesterday with mostly bug fixes, so integrating it here before we ship.

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@michael-hawker michael-hawker added nuget 📦 WinUI 💠 Related to WinUI 3 Version or when paired with External can mean requires fix in WinUI 2/3. priority 🚩 labels Sep 16, 2021
@michael-hawker michael-hawker added this to the 7.1 milestone Sep 16, 2021
@ghost
Copy link

ghost commented Sep 16, 2021

Thanks michael-hawker for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from azchohfi and Rosuavio September 16, 2021 17:51
Copy link
Contributor

@Rosuavio Rosuavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went threw and looked at all the samples and noticed no issues.

@michael-hawker
Copy link
Member Author

Weird the integration tests failed:

Error: System.Exception: Failed to install Test Appx Package: error 0x80070002: Opening the package from location Microsoft.UI.Xaml.2.6.appx failed.
   at Windows.UI.Xaml.Tests.MUXControls.InteractionTests.Infra.TestAppInstallHelper.InstallTestAppIfNeeded(String deploymentDir, String packageName, String packageFamilyName, String appInstallerName)
   at Windows.UI.Xaml.Tests.MUXControls.InteractionTests.Infra.Application.Launch(String deploymentDir)
   at Windows.UI.Xaml.Tests.MUXControls.InteractionTests.Infra.Application.Initialize(Boolean doLaunch, String deploymentDir)
   at Windows.UI.Xaml.Tests.MUXControls.InteractionTests.Infra.TestEnvironment.Initialize(TestContext testContext, TestApplicationInfo testAppInfo)
   at UITests.Tests.SimpleTest.ClassInitialize(TestContext testContext) in /_/UITests/UITests.Tests.Shared/Examples/SimpleTest.cs:line 28
Saved screen capture to "D:\a\1\s\build\WexLogFileOutput\000039_Screenshot.jpg".
Error: TAEF: Setup fixture 'ClassInitialize' for the scope 'UITests.Tests.SimpleTest' failed.
Saved screen capture to "D:\a\1\s\build\WexLogFileOutput\000040_Screenshot.jpg".

Maybe I have to update another dependency somewhere? Maybe we forgot the incremental update before so I missed it this time around. Let me look...

@michael-hawker
Copy link
Member Author

Ah, there's a text file for dependencies, trying to update that. Validated the MSTest ones work fine locally:

image

@ghost
Copy link

ghost commented Sep 16, 2021

Hello @michael-hawker!

Because this pull request has the auto merge :zap: label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 5 hours 5 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@michael-hawker michael-hawker merged commit 7816189 into CommunityToolkit:main Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merge ⚡ nuget 📦 priority 🚩 WinUI 💠 Related to WinUI 3 Version or when paired with External can mean requires fix in WinUI 2/3.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants