Fixed incorrect paths for pipeline sample resources #4280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
requested a review
from 
ghost
added
bug 🐛
XAML-Knight
suggested changes
Sep 27, 2021
Microsoft.Toolkit.Uwp.SampleApp/SamplePages/ImageBlendBrush/ImageBlendBrushXaml.bind
Show resolved
Hide resolved
|
This PR has been marked as "needs attention 👋" and awaiting a response from the team. |
michael-hawker
approved these changes
Oct 6, 2021
There was a problem hiding this comment.
Looks good, thanks @Sergio0694. I guess an interesting behavior is that if one path is wrong the whole brush fails to load I guess? I think that's why I thought something more might be going on and didn't think of just the unicorn/trex paths changing.
Wonder if we'd want to change this behavior in the future?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4275
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The pipeline samples are currently broken. This is not due to a bug in the pipeline APIs themselves, but just by the fact that following #4179, the
DropShadowPanel/Unicorn.pngresource was moved toShadows/Unicorn.png, but those other pipeline sample pages weren't updated. This caused that image loading to fail, and the whole pipeline brush to stop working.What is the new behavior?
Updated the resource path in those sample pages.
Screenshot
PR Checklist
Please check if your PR fulfills the following requirements: