Implement parallel diversity calculation #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jacob-Chmura
commented
Mar 1, 2025
aif_gen/_cli/commands/validate.py
Outdated
| '--num-workers', | ||
| type=click.IntRange(min=1, max=32, clamp=True), | ||
| help='Number of sub-process workers to spawn for computing diversity validation.', | ||
| default=4, |
There was a problem hiding this comment.
Arguably we should default to os.process_cpu_count()
| logging.info('Downloading NLTK resources.') | ||
| nltk.download('averaged_perceptron_tagger', quiet=True) | ||
| nltk.download('punkt', quiet=True) | ||
| required_resources = ['punkt_tab'] |
There was a problem hiding this comment.
I did a hard wipe of my cache and found that this is the only hard requirement for the needed nltk resource
Jacob-Chmura
commented
Mar 1, 2025
| '--num-workers', | ||
| type=click.IntRange(min=1, max=64, clamp=True), | ||
| help='Number of sub-process workers to spawn for computing diversity validation.', | ||
| default=os.cpu_count(), |
There was a problem hiding this comment.
Note, since we are running python3.9 we don't have access to os.process_cpu_count() which could be strictly lower than os.cpu_count() depending on cpu affinity. Hence, this could in theory over-spawn processes, but I don't think it is a big deal.
More info: python/cpython#109649
EMZEDI
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #71