Skip to content

bug fix, code cleanup + dedicated test for installation lock #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 30, 2020
Merged

bug fix, code cleanup + dedicated test for installation lock #20

merged 10 commits into from
Mar 30, 2020

Conversation

boegel
Copy link

@boegel boegel commented Mar 29, 2020

@mboisson for easybuilders#3009

High-level overview of changes:

  • make sure installation actually proceeds after lock is removed when --wait-on-lock is used
  • don't print messages when lock is acquired/removed (should be done in background)
  • make wait interval configurable by letting --wait-on-lock accept an argument
  • renamed --lockpath to --locks-dir
  • added --ignore-locks option
  • add dedicated test to check lock feature & related configuration options
  • code cleanup

mboisson
mboisson reviewed Mar 30, 2020
View reviewed changes
@mboisson mboisson merged commit e39976b into ComputeCanada:build_lock Mar 30, 2020
mboisson pushed a commit that referenced this pull request Oct 17, 2022
@akesandgren
Merge pull request #20 from boegel/fix-obtain_files-for-patch-with-al…
042d57a 
…t_location

always log a message in obtain_file to indicate whether or directory in which easyconfig file is located is being consider to locate file + enhance test_obtain_file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboisson mboisson mboisson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boegel @mboisson