add grammar-based testing script #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+137
to
+138
| if name == 'element': | ||
| return # TODO: propagator not yet implemented? |
There was a problem hiding this comment.
I am trying to understand this guard statement. Removing it seems to work fine; the element propagator is implemented and accessible through the python interface. Am I missing something?
There was a problem hiding this comment.
I think when I tested it before, the reification of Element gave me an error.
Maybe it has to do with the index being able to go out of bounds in this testing script?
thread '<unnamed>' panicked at pumpkin-solver/src/engine/cp/propagation/contexts/propagation_context.rs:101:43:
not yet implemented
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
[1] 87643 IOT instruction (core dumped) python3 scratch.py
|
This will be merged after #151 is merged! |
maartenflippo
approved these changes
Feb 13, 2025
maartenflippo
pushed a commit
that referenced
this pull request
Apr 11, 2025
I added a script that automatically generates a bunch of constraints and posts them through the Python API. Some bugs I have found (annotated with TODO in the script): - Scaling with "0" results in division-by zero errors for some constraints - The reified propagator for Element seems to be unimplemented for now? Ideally, we can also test whether the constraint is indeed satisfied by the solution found by the solver, but I'm not sure how to that.
maartenflippo
pushed a commit
that referenced
this pull request
Apr 11, 2025
I added a script that automatically generates a bunch of constraints and posts them through the Python API. Some bugs I have found (annotated with TODO in the script): - Scaling with "0" results in division-by zero errors for some constraints - The reified propagator for Element seems to be unimplemented for now? Ideally, we can also test whether the constraint is indeed satisfied by the solution found by the solver, but I'm not sure how to that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a script that automatically generates a bunch of constraints and posts them through the Python API.
Some bugs I have found (annotated with TODO in the script):
Ideally, we can also test whether the constraint is indeed satisfied by the solution found by the solver, but I'm not sure how to that.