This repository was archived by the owner on Feb 26, 2024. It is now read-only.
ci: remove node 12 from CI tests#4029
Merged
MicaiahReid merged 4 commits intodevelopfrom Dec 15, 2022
Merged
Conversation
Co-authored-by: David Murdoch <187813+davidmurdoch@users.noreply.github.com>
MicaiahReid
requested review from
davidmurdoch,
satyajeetkolhapure and
tenthirtyone
davidmurdoch
approved these changes
Dec 15, 2022
cds-amal
approved these changes
Dec 15, 2022
Contributor
cds-amal
left a comment
cds-amal
left a comment
There was a problem hiding this comment.
Looks good, @MicaiahReid, just one small nit, which won't hold back my approval.
|
|
||
| #### v7.7.0+, Dropped support for Node v12 | ||
|
|
||
| We no longer support Node v12. You'll need to update to Node v14.0.0 or later. NOTE: Support for Node.js v14.x.x will be dropped shortly after the Node.js Foundation stops supporting it in April 2023. |
Contributor
There was a problem hiding this comment.
Suggested change
| We no longer support Node v12. You'll need to update to Node v14.0.0 or later. NOTE: Support for Node.js v14.x.x will be dropped shortly after the Node.js Foundation stops supporting it in April 2023. | |
| We no longer support Node v12. You'll need to update to Node v14 or later. NOTE: Support for Node.js v14 will be dropped shortly after the Node.js Foundation stops supporting it in April 2023. |
I think the extra zeros and .x.x are confusing in this context.
Contributor
Author
There was a problem hiding this comment.
I disagree; this is saying you currently need at least the lowest v14, which is 14.0.0. And that we will drop support for all node v14 versions, 14.x.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You know when you spend a really long time on a big PR and finally think you've got every little detail settled, then the whole team reviews the PR and finds a few other little things that you fix, then they all approve the PR, so you all think you've got every little detail settled, then you finally merge the PR and you immediately realize that you forgot to remove a now unsupported version of node from your CI tests that only run once the PR has been merged into develop, so now you have to make another PR to remove the now unsupported node version from your CI tests? Yeah I hate when that happens.