This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix: add leveldown back to bundle for Windows installation#4046
Merged
davidmurdoch merged 7 commits intodevelopfrom Dec 16, 2022
Merged
fix: add leveldown back to bundle for Windows installation#4046davidmurdoch merged 7 commits intodevelopfrom
davidmurdoch merged 7 commits intodevelopfrom
Conversation
davidmurdoch
requested review from
MicaiahReid,
jeffsmale90 and
tenthirtyone
davidmurdoch
commented
Dec 16, 2022
davidmurdoch
commented
Dec 16, 2022
tenthirtyone
approved these changes
Dec 16, 2022
satyajeetkolhapure
approved these changes
Dec 16, 2022
Contributor
satyajeetkolhapure
left a comment
satyajeetkolhapure
left a comment
There was a problem hiding this comment.
Approved. Tested the fix on Windows 11. It works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For reasons not yet understood, the
leveldownpackage must be bundled or installations on Windows without windows-build-tools installed fails. This puts theleveldownpackage back into theganachepackage'sbundledDependencies.This PR also introduces changes to our CI process to build a release candidate tarball during test runs.
Fixes #3661