Lcra/change security visibility per role prod 14083 #836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified tests in all services after role_viewer got the right to read security
added check in each services for each returned objects containing security if security was returned and the user has the role viewer then only minimal informations on security are returned default security is unchanged, the access control list contains only the user with the role viewer
Leopold-Cramer
force-pushed
the
LCRA/change_security_visibility_per_role_PROD-14083
branch
from
f652815 to
4a44eb5
Compare
sellisd
reviewed
Dec 30, 2024
| } | ||
|
|
||
| @Test | ||
| fun `test update solution with runTemplates specified`() { |
sellisd
reviewed
Dec 30, 2024
| } | ||
|
|
||
| @Test | ||
| fun `test update solution with empty runTemplates specified`() { |
sellisd
approved these changes
Dec 31, 2024
There was a problem hiding this comment.
after applying PROD-13734 fix and correcting versions seems to me ok for merging
sellisd
deleted the
LCRA/change_security_visibility_per_role_PROD-14083
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.