Skip to content

Force DuplicatePolicy for Redis TS created programmatically by Cosmotech #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Force DuplicatePolicy for Redis TS created programmatically by Cosmotech #852

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions metrics/src/main/kotlin/com/cosmotech/metrics/MetricsServiceImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import org.slf4j.LoggerFactory
import org.springframework.context.event.EventListener
import org.springframework.stereotype.Service
import redis.clients.jedis.UnifiedJedis
import redis.clients.jedis.timeseries.DuplicatePolicy
import redis.clients.jedis.timeseries.TSAlterParams
import redis.clients.jedis.timeseries.TSCreateParams

Expand Down Expand Up @@ -58,7 +59,12 @@ class MetricsServiceImpl(
val metricLabels = getMetricLabels(commonLabels)
logger.debug(
"Creating Redis TS: $key with retention: $metricRetention and ${metricLabels.count()} labels")
unifiedJedis.tsCreate(key, TSCreateParams().retention(metricRetention).labels(metricLabels))
unifiedJedis.tsCreate(
key,
TSCreateParams()
.retention(metricRetention)
.labels(metricLabels)
.duplicatePolicy(DuplicatePolicy.MAX))
if (metric.downSampling || csmPlatformProperties.metrics.downSamplingDefaultEnabled) {
val downSamplingKey = getDownSamplingKey(metric)
val downSamplingMetricLabels = getDownSamplingMetricLabels(commonLabels)
Expand All @@ -69,7 +75,10 @@ class MetricsServiceImpl(
"and ${downSamplingMetricLabels.count()} labels")
unifiedJedis.tsCreate(
downSamplingKey,
TSCreateParams().retention(downSamplingRetention).labels(downSamplingMetricLabels))
TSCreateParams()
.retention(downSamplingRetention)
.labels(downSamplingMetricLabels)
.duplicatePolicy(DuplicatePolicy.MAX))
logger.debug(
"Creating Redis DownSampling TS rule: from $key to $downSamplingKey, " +
"aggregation: ${metric.downSamplingAggregation.value}, bucketDuration: $downSamplingBucketDuration")
Expand All @@ -89,7 +98,12 @@ class MetricsServiceImpl(
logger.debug(
"Redis TS library cannot get current labels so it is not possible to check if labels changed")
val metricLabels = getMetricLabels(commonLabels)
unifiedJedis.tsAlter(key, TSAlterParams().retention(metricRetention).labels(metricLabels))
unifiedJedis.tsAlter(
key,
TSAlterParams()
.retention(metricRetention)
.labels(metricLabels)
.duplicatePolicy(DuplicatePolicy.MAX))
} else {}
}
}
Expand Down
Loading