Skip to content

fix: upgrade to python > 3.8 #868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Conversation

sellisd
Copy link
Contributor

@sellisd sellisd commented Feb 18, 2025

we can bring up the openapi-generator to v.7.10.0 (but not to latest stable 7.11 without breaking things).

With this minor upgrade to 7.10.0 the generated python client has as minimum requirement python 3.8 instead of 3.7. Both 3.7 and 3.8 versions have reached their end-of-life but at least 3.8 is still available in the github ubuntu latest runners. With this minor change we will be able to avoid a failed github action in the generated python client

@sellisd sellisd marked this pull request as draft February 18, 2025 16:47
@sellisd sellisd marked this pull request as ready for review February 18, 2025 17:05
Copy link
Contributor

@sjoubert sjoubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: maybe change the commit message to something like "upgrade openapi generator to be compliant with python > 3.8". Before looking at the commit diff I was expecting an upgrade of some python tools/requirements not the openapi generator.

@sellisd sellisd force-pushed the DSE/fix_client_cicd_PROD-14252 branch from d8b293d to 99282e9 Compare February 19, 2025 09:47
@sellisd sellisd merged commit 9537a73 into main Feb 19, 2025
33 checks passed
@sellisd sellisd deleted the DSE/fix_client_cicd_PROD-14252 branch February 19, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants