Skip to content

Lcra/refactor solution openapi prod 14210 #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 25, 2025

Conversation

Leopold-Cramer
Copy link
Contributor

No description provided.

Copy link
Member

@jreynard-code jreynard-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some remarks :)
Feel free to ask if something needs to be clarified

@Leopold-Cramer Leopold-Cramer force-pushed the LCRA/refactor_solution_openapi_PROD-14210 branch 2 times, most recently from 0751bb1 to ca8348b Compare February 24, 2025 10:56
Copy link
Contributor

@sjoubert sjoubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the DeleteHistoricalData* event are not used don't forget to remove them from the common repo as well.

Copy link
Member

@jreynard-code jreynard-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some remark, nothing big to change 😅
GG btw!

@Leopold-Cramer Leopold-Cramer force-pushed the LCRA/refactor_solution_openapi_PROD-14210 branch from ca8348b to c60bbf0 Compare February 24, 2025 15:33
Copy link
Member

@jreynard-code jreynard-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ;)

@Leopold-Cramer Leopold-Cramer merged commit d04ffe9 into main Feb 25, 2025
33 checks passed
@Leopold-Cramer Leopold-Cramer deleted the LCRA/refactor_solution_openapi_PROD-14210 branch February 25, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants