-
Notifications
You must be signed in to change notification settings - Fork 2
Lcra/refactor solution openapi prod 14210 #870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lcra/refactor solution openapi prod 14210 #870
Conversation
…+ modified examples
…lution creation and update
solution/src/main/kotlin/com/cosmotech/solution/service/SolutionServiceImpl.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some remarks :)
Feel free to ask if something needs to be clarified
0751bb1
to
ca8348b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that the DeleteHistoricalData*
event are not used don't forget to remove them from the common repo as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some remark, nothing big to change 😅
GG btw!
organization/src/main/kotlin/com/cosmotech/organization/service/OrganizationServiceImpl.kt
Show resolved
Hide resolved
solution/src/main/kotlin/com/cosmotech/solution/service/SolutionServiceImpl.kt
Outdated
Show resolved
Hide resolved
solution/src/main/kotlin/com/cosmotech/solution/service/SolutionServiceImpl.kt
Outdated
Show resolved
Hide resolved
… properties requirements more precise
ca8348b
to
c60bbf0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ;)
No description provided.