Skip to content

License does not serialize license_url to the output. #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
schlenk opened this issue Feb 21, 2022 · 2 comments · Fixed by #180
Closed

License does not serialize license_url to the output. #179

schlenk opened this issue Feb 21, 2022 · 2 comments · Fixed by #180
Assignees
@madpah
Labels
bug Something isn't working
Milestone
2.0.0

Comments

@schlenk
Copy link
Contributor

schlenk commented Feb 21, 2022 •
edited
Loading

The license_url optional field is not serialized to the XML output.
The spec recommends to also add the ExternalReference with type LICENSE, but i would expect the URL in the output, if it is given as part of the License type.

Probably just missing in the code here:

cyclonedx-python-lib/cyclonedx/output/xml.py

Line 159 in 9e80258

if license.license:

Seen using cyclonedx-python-lib 1.3.0, but the code seems identical in the main branch.
@madpah
Copy link
Collaborator

madpah commented Feb 21, 2022

Hi @schlenk - thanks for the report. Totally correct here - bug discovered.

Will get this fixed and into the next release (due this week).

@madpah madpah self-assigned this Feb 21, 2022
@madpah madpah added the bug Something isn't working label Feb 21, 2022
@madpah madpah added this to the 2.0.0 milestone Feb 21, 2022
@madpah madpah mentioned this issue Feb 21, 2022
Merged
madpah added a commit that referenced this issue Feb 21, 2022
@madpah
fix: license_url not serialised in XML output #179
dcfd76c 
Signed-off-by: Paul Horton <[email protected]>
@madpah madpah mentioned this issue Feb 21, 2022
Merged
@madpah madpah linked a pull request Feb 21, 2022 that will close this issue
fix: license_url not serialised in XML output #179 #180
Merged
madpah added a commit that referenced this issue Feb 21, 2022
@madpah
fix: license_url not serialised in XML output #179 (#180)
f014d7c 
Signed-off-by: Paul Horton <[email protected]>
@madpah
Copy link
Collaborator

madpah commented Feb 21, 2022

https://pypi.org/project/cyclonedx-python-lib/2.0.0/ released.

@madpah madpah closed this as completed Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@madpah madpah

Labels
bug Something isn't working
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

fix: license_url not serialised in XML output #179 CycloneDX/cyclonedx-python-lib
2 participants
@schlenk @madpah