BREAKING CHANGE: update models to use Set rather than List
#160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n `List[..]` BREAKING CHANGE: update final models to use `@property` wip Signed-off-by: Paul Horton <[email protected]>
Signed-off-by: Paul Horton <[email protected]>
Signed-off-by: Paul Horton <[email protected]>
… from `List` fix: change to how we are comparing XML output in tests so we do not care about element ordering Signed-off-by: Paul Horton <[email protected]>
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
Signed-off-by: Paul Horton <[email protected]>
Signed-off-by: Paul Horton <[email protected]>
Signed-off-by: Paul Horton <[email protected]>
Signed-off-by: Paul Horton <[email protected]>
jkowalleck
reviewed
Feb 7, 2022
jkowalleck
reviewed
Feb 7, 2022
There was a problem hiding this comment.
all reviewd. added some remarks.
the outcome is such a milestone. 💟
now it is possible to create the structures and simply pass in the generators/iterables as parameters. which will make the cyclonedx-python likely more pythonic.
like
components = makeComponentFromRequirement(line) for line in requirements # is a generator and no data is actually generated, until it is resolved
Bom(components=components)Signed-off-by: Paul Horton <[email protected]>
Signed-off-by: Paul Horton <[email protected]>
Merged
|
also fixed #176 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR looks to implement #159 for the reasons stated there.
As part of this, we have had to make our unit tests even better:
Resolves #159