-
-
Notifications
You must be signed in to change notification settings - Fork 50
fix: BOM validation fails when Components or Services are nested #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Paul Horton <[email protected]>
Signed-off-by: Paul Horton <[email protected]>
Signed-off-by: Paul Horton <[email protected]>
Signed-off-by: Paul Horton <[email protected]>
Signed-off-by: Paul Horton <[email protected]>
ran isort Signed-off-by: Paul Horton <[email protected]>
This reverts commit f50ee1e. Signed-off-by: Paul Horton <[email protected]>
Signed-off-by: Paul Horton <[email protected]>
Signed-off-by: Paul Horton <[email protected]>
Signed-off-by: Paul Horton <[email protected]>
907fec9
to
d6955cb
Compare
Comments address - review not dismissing?
@madpah no issue with your implementation. it is solid. and i would not change it at all. but i thing a tree iterator algorithm on the Set of why i thing it fits better? Because the set is already a collection - that is iterated. did this in the JS implementation: https://github.com/CycloneDX/cyclonedx-javascript-library/pull/136/files#diff-91e0bfb8ec98ef0ee09645d5c3ccbfec3d1fcafcc0d74e81c7e3cb08ed0aee31R141-R146 |
This PR will address the root issue raised in #275.
Fixes:
This PR will also address the following dependency updates: