-
-
Notifications
You must be signed in to change notification settings - Fork 49
BREAKING CHANGE: remove support for Python3.6 #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING CHANGE: remove support for Python3.6 #325
Conversation
Signed-off-by: Hakan Dilek <[email protected]>
LGTM. sometimes the CI/CT failed. appears to be for the poetry lockfile being broken, outdated, or something ... @hakandilek would you be so kind and re-generate a working poetry lock? it it did not work on first try, just leave it as is. |
Signed-off-by: Hakan Dilek <[email protected]>
I did regenerate it but I suppose the problem is the incompatibility with the
|
@madpah could you have a look at this? |
Hey @hakandilek - thanks for the contribution. I just cloned your branch and all tests pass locally for me - I am not getting the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - assuming we can get tests to pass on CI.
@hakandilek - found the root cause I believe. Can you update your branch from main (merge our main into your branch) please? There was a fix added to |
Signed-off-by: Hakan Dilek <[email protected]>
Well, exactly did that. Please review, |
The patched poetry lock file was incompatible to the version of poetry we are running - which is pinned to @madpah do we want to bump our env to poetry 1.3? Should we add this constraint to the dev-requirements in our docs/CONTRIBUTING file? FYI: it is possible to have multiple versions of poetry installed in parallel |
Thanks @jkowalleck. Bit tricky to move We're going to have to take this into Leave with me @hakandilek / @jkowalleck . |
This is my contribution for #292 as discussed on #317