Skip to content

BREAKING CHANGE: remove support for Python3.6 #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 23, 2023
Merged

BREAKING CHANGE: remove support for Python3.6 #325

merged 6 commits into from
Jan 23, 2023

Conversation

hakandilek
Copy link
Contributor

This is my contribution for #292 as discussed on #317

@hakandilek hakandilek requested a review from a team as a code owner December 16, 2022 20:55
@jkowalleck jkowalleck requested a review from madpah December 16, 2022 22:33
@jkowalleck jkowalleck changed the title Drop Python 3.6 support BREAKING CHANGE: support for Python 3.6 was support Dec 16, 2022
@jkowalleck jkowalleck changed the title BREAKING CHANGE: support for Python 3.6 was support BREAKING CHANGE: remove support for Python3.6 Dec 17, 2022
@jkowalleck
Copy link
Member

jkowalleck commented Dec 17, 2022

LGTM.

sometimes the CI/CT failed. appears to be for the poetry lockfile being broken, outdated, or something ...

@hakandilek would you be so kind and re-generate a working poetry lock? it it did not work on first try, just leave it as is.

@hakandilek
Copy link
Contributor Author

@hakandilek would you be so kind and re-generate a working poetry lock? it it did not work on first try, just leave it as is.

I did regenerate it but I suppose the problem is the incompatibility with the importlib-metadata on Python 3.7:

poetry 1.3.1 requires importlib-metadata<5.0,>=4.4; python_version < "3.10", but you have importlib-metadata 3.4.0 which is incompatible.
keyring 23.11.0 requires importlib-metadata>=4.11.4; python_version < "3.12", but you have importlib-metadata 3.4.0 which is incompatible.

@jkowalleck
Copy link
Member

@madpah could you have a look at this?

@jkowalleck jkowalleck added this to the 4.0.0 milestone Jan 12, 2023
@madpah
Copy link
Collaborator

madpah commented Jan 20, 2023

Hey @hakandilek - thanks for the contribution.

I just cloned your branch and all tests pass locally for me - I am not getting the importlib-metadata conflict that we see in CI - so will have to dig a bit deeper.

Copy link
Collaborator

@madpah madpah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - assuming we can get tests to pass on CI.

@madpah
Copy link
Collaborator

madpah commented Jan 20, 2023

@hakandilek - found the root cause I believe.

Can you update your branch from main (merge our main into your branch) please?

There was a fix added to tox.ini which is not in your branch which is breaking the tests.

@madpah madpah mentioned this pull request Jan 20, 2023
@hakandilek
Copy link
Contributor Author

hakandilek commented Jan 20, 2023

Can you update your branch from main (merge our main into your branch) please?

Well, exactly did that. Please review,

@jkowalleck
Copy link
Member

jkowalleck commented Jan 23, 2023

The patched poetry lock file was incompatible to the version of poetry we are running - which is pinned to 1.1.11.

@madpah do we want to bump our env to poetry 1.3?
Or should we ask @hakandilek to use v1.1 to generate the logs?

Should we add this constraint to the dev-requirements in our docs/CONTRIBUTING file?

FYI: it is possible to have multiple versions of poetry installed in parallel
Achieved this here via pipx as described in the poetry docs.

@madpah
Copy link
Collaborator

madpah commented Jan 23, 2023

Thanks @jkowalleck. Bit tricky to move poetry version right now and we're close to getting some cyclical dependencies between features :-(

We're going to have to take this into 4.0.0 branch via another branch I think to get this moving.

Leave with me @hakandilek / @jkowalleck .

@madpah madpah changed the title BREAKING CHANGE: remove support for Python3.6 BREAKING CHANGE: remove support for Python3.6 Jan 23, 2023
@madpah madpah changed the base branch from dev/4.0.0 to feat/deserialization-to-object-model January 23, 2023 18:32
@madpah madpah merged commit ac390fe into CycloneDX:feat/deserialization-to-object-model Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants