Merged
Conversation
jkowalleck
commented
Sep 14, 2023
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck
force-pushed
the
ship-meta-files
branch
from
dee2f7a to
001d7bd
Compare
Member
Author
|
caused #435 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
some meta files are not bundled/packaged/shipped
for example the NOTICE file was missing. This file contains additional information to the LICENSE file.
cannot do as shown in https://github.com/python-poetry/poetry/blob/a8987e3e88f033601fc1059a6540fb7b675b7d08/README.md?plain=1#L33-L34
since this would concatenate all the files.
instead, they are about to be shipped as is ...
the
includeputs the files in the package,but might also cause them to be unpacked in
site-packageson installation, but that should do no harm, though it is ugly ...cannot do any better. thanks, poetry.