Add SplitFunctions to split domains in hypercubes#1521
Open
phcerdan wants to merge 3 commits intoDGtal-team:mainfrom
Open
Add SplitFunctions to split domains in hypercubes#1521phcerdan wants to merge 3 commits intoDGtal-team:mainfrom
phcerdan wants to merge 3 commits intoDGtal-team:mainfrom
Conversation
phcerdan
force-pushed
the
split_functions0
branch
2 times, most recently
from
68c948a to
2b397e4
Compare
Member
Author
|
This is a rebase from #1448. The thinning algorithm with splits was discarded. |
Given a domain defined by lower and upper bound points and requested_number_of_splits implements two functions: - computeSplits returns the number of splits that the region can hold (lesser or equal than the requested) - getSplit returns the ith split and the outputLowerBound and outputUpperBound of the split region. Implementation acquired from ITK: itkImageRegionSplitterMultidimensional.cxx https://github.com/InsightSoftwareConsortium/ITK/blob/f971477cdacff22a861dfcbaccd89c0cf2755af7/Modules/Core/Common/src/itkImageRegionSplitterMultidimensional.cxx - Add splitComplex to SplitFunctions - Add test and change testSplitFunctions to use Catch
phcerdan
force-pushed
the
split_functions0
branch
from
2b397e4 to
4fac550
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given a domain defined by lower and upper bound points and
requested_number_of_splits implements two functions:
region can hold (lesser or equal than the requested)
outputUpperBound of the split region.
Implementation acquired from ITK: itkImageRegionSplitterMultidimensional.cxx
https://github.com/InsightSoftwareConsortium/ITK/blob/f971477cdacff22a861dfcbaccd89c0cf2755af7/Modules/Core/Common/src/itkImageRegionSplitterMultidimensional.cxx
Checklist
cmakemode (otherwise, Travis C.I. will fail).