Draft
Conversation
Member
|
Few hints:
|
Member
|
documentation : |
added 9 commits
June 29, 2021 14:57
Member
|
It looks like I cannot push to your branch anymore. Have you changed something? |
Member
|
I just did a PR on your repo (not great). Could you please check the permissions? |
… Map (not working yet)
dcoeurjo
reviewed
Jul 15, 2021
| Eigen::Vector3f b; | ||
| int b1, b2, b3; | ||
|
|
||
| b1 = -(pow(B[0], 2) - pow(A[0], 2) + pow(B[1], 2) - pow(A[1], 2) + pow(B[2], 2) - pow(A[2], 2)); |
Member
There was a problem hiding this comment.
casting to int may not be a great idea.
dcoeurjo
reviewed
Jul 15, 2021
| b3 = -(pow(D[0], 2) - pow(A[0], 2) + pow(D[1], 2) - pow(A[1], 2) + pow(D[2], 2) - pow(A[2], 2)); | ||
| b << b1, b2, b3; | ||
|
|
||
| M << 2*(A[0] - B[0]) , 2*(A[1] - B[1]) , 2*(A[2] - B[2]) , |
Member
There was a problem hiding this comment.
should use arithmetic on PointVector
| @@ -0,0 +1,98 @@ | |||
| /** | |||
Member
There was a problem hiding this comment.
test not included in the CMakeLists.txt
Member
|
Closing this PR.Stalled for many years. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
your description here
Checklist
cmakemode (otherwise, Travis C.I. will fail).