Skip to content

fix: cs conversion takes into account all the parent classes (fix #752) #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aldbr merged 1 commit into from
Jan 27, 2026
Merged

fix: cs conversion takes into account all the parent classes (fix #752) #753

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion diracx-core/src/diracx/core/config/schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,15 @@ def legacy_adaptor(cls, v):
"SerializableSet[str]",
"SerializableSet[SecurityProperty]",
}
for field, hint in cls.__annotations__.items():

# To support inheritance, we have to find the annotation of all the MRO
# Skip the first classes (object, Pydantic.BaseModel, our BaseModel )
mro_annotations = {}
for mro_cls in cls.__mro__[::-1]:
if issubclass(mro_cls, BaseModel) and mro_cls != BaseModel:
mro_annotations.update(mro_cls.__annotations__)

for field, hint in mro_annotations.items():
# Convert comma separated lists to actual lists
if hint.startswith("set"):
raise NotImplementedError("Use SerializableSet instead!")
Expand Down
Loading