fix(spotify/artist): include all music#21593
Open
jameschubbuck wants to merge 1 commit intoDIYgod:masterfrom
Open
fix(spotify/artist): include all music#21593jameschubbuck wants to merge 1 commit intoDIYgod:masterfrom
jameschubbuck wants to merge 1 commit intoDIYgod:masterfrom
Conversation
Contributor
Auto ReviewNo clear rule violations found in the current diff. |
github-actions
bot
added
auto: not ready to review
Contributor
|
Successfully generated as following: http://localhost:1200/spotify/artist - Failed ❌ |
TonyRL
reviewed
Apr 3, 2026
| }, | ||
| }); | ||
| const itemsResponse = await ofetch(`https://api.spotify.com/v1/artists/${id}/albums`, { | ||
| const itemsResponse = await ofetch(`https://api.spotify.com/v1/artists/${id}/albums?include_groups=album,single,ep,appears_on,compilation`, { |
Collaborator
There was a problem hiding this comment.
ep is not one of the valid values from https://developer.spotify.com/documentation/web-api/reference/get-an-artists-albums
Author
There was a problem hiding this comment.
Oh - my bad. Do you know how to include EPs? I didn't see them show up in any other field so assumed that it must exist.
Collaborator
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Involved Issue / 该 PR 相关 Issue
Close #
Example for the Proposed Route(s) / 路由地址示例
New RSS Route Checklist / 新 RSS 路由检查表
PuppeteerNote / 说明
By default the artist endpoint only returns albums and omits other types. It would be better to include them.