Problem authorship#2303
Open
FherStk wants to merge 1 commit into
Open
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2303 +/- ##
==========================================
+ Coverage 46.76% 46.83% +0.06%
==========================================
Files 251 253 +2
Lines 13317 13360 +43
==========================================
+ Hits 6228 6257 +29
- Misses 7089 7103 +14 ☔ View full report in Codecov by Sentry. |
int-y1
reviewed
Dec 26, 2023
Ninjaclasher
reviewed
Jan 2, 2024
Member
Ninjaclasher
left a comment
Ninjaclasher
left a comment
There was a problem hiding this comment.
Just some minor nits, otherwise LGTM, thanks!
FherStk
force-pushed
the
problem_authorship
branch
2 times, most recently
from
be25e61 to
d38bc14
Compare
Contributor
Author
|
Ready to merge, changes from #2304 have been integrated :) |
FherStk
force-pushed
the
problem_authorship
branch
2 times, most recently
from
c35f69b to
c6cbea5
Compare
… will be displayed at the end of the problem's statement.
FherStk
force-pushed
the
problem_authorship
branch
from
663d217 to
341d70c
Compare
Contributor
Author
|
Hi there! I just integrated your "master" last changes into this branch, and also I finally learned how to squash commits properly (sorry for the delay), so ready to rock'n'roll 😊 I'll keep the branch unmodified till the PR acceptance, but feel free to ask or request as you need if you need further modifications. Kind regards! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related with: #2298
Related also with: #144
A new option has been included for attribution purposes, in order to give the authorship to external DMOJ users (like websites, books, etc):
This data will be displayed at the end of the problem statement, just before the license:
Thanks and have a nice Xmas!
Fher