feat: reimplement storage class with hashicorp/kubernetes provider#9
Open
mercuriete wants to merge 1 commit intoDNXLabs:masterfrom
Open
feat: reimplement storage class with hashicorp/kubernetes provider#9mercuriete wants to merge 1 commit intoDNXLabs:masterfrom
mercuriete wants to merge 1 commit intoDNXLabs:masterfrom
Conversation
mercuriete
commented
Dec 1, 2021
88bda01 to
bf1a588
Compare
bf1a588 to
918b1ba
Compare
Contributor
This is how i ended up doing our SC for dynamic provisioning, straight out the controller YAML example. |
oxr463
approved these changes
Feb 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8
Motivation in our internal CICD system the kubectl provider was not working properly and we want to use an official provider for doing that functionality.
It is not a breaking change but It will destroy the storage class and create another one with the same name.
This was tested on my internal EKS cluster and everything worked properly.
Types of changes
What types of changes does your code introduce to <repo_name>?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.