Update GitHub Actions CI #229
Conversation
WalkthroughThe continuous integration workflows were updated to use newer operating systems and toolchains: Windows jobs now use Visual Studio 2022 on Windows Server 2022, and Linux jobs use Ubuntu 24.04. Additionally, Visual Studio 2019 build configurations were removed from the Windows workflow, streamlining the build matrix. Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/linux.yml (1)
46-46: Deprecation warning:apt-keyis deprecated
Theapt-key addcommand is deprecated on newer Ubuntu releases. Consider switching to asigned-bymechanism by de-armoring the key and referencing it in/etc/apt/sources.list.d.- wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key | sudo apt-key add - + wget -qO - https://apt.llvm.org/llvm-snapshot.gpg.key \ + | gpg --dearmor | sudo tee /usr/share/keyrings/llvm-archive-keyring.gpg >/dev/null - sudo apt-add-repository "deb http://apt.llvm.org/$(lsb_release -cs)/ ${{ matrix.Repo }} main" + echo "deb [signed-by=/usr/share/keyrings/llvm-archive-keyring.gpg] http://apt.llvm.org/$(lsb_release -cs)/ ${{ matrix.Repo }} main" \ + | sudo tee /etc/apt/sources.list.d/llvm.list
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/cmake.yml(1 hunks).github/workflows/linux.yml(2 hunks).github/workflows/windows.yml(0 hunks)
💤 Files with no reviewable changes (1)
- .github/workflows/windows.yml
⏰ Context from checks skipped due to timeout of 90000ms (7)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: ubuntu-24.04 g++-10
- GitHub Check: VS2022Debug64
- GitHub Check: windows-2022 vs2022
- GitHub Check: macos-14-C++17
- GitHub Check: VS2022Release32
- GitHub Check: macos-13-C++17
🔇 Additional comments (2)
.github/workflows/linux.yml (1)
26-26:❌ Incorrect review comment
Critical: Runner label
ubuntu-24.04may not be supported
GitHub-hosted runners currently provideubuntu-20.04,ubuntu-22.04, andubuntu-latest(22.04). Ifubuntu-24.04isn’t yet available, this job will fail. Please confirm runner availability or revert to a supported label.
🌐 Web query:
Which GitHub Actions runner labels are currently supported for Ubuntu images? Specifically, is `ubuntu-24.04` available?💡 Result:
GitHub Actions provides several runner labels for Ubuntu images, each corresponding to a specific version of Ubuntu. As of June 2025, the available Ubuntu runner labels are:
ubuntu-latestubuntu-24.04ubuntu-22.04ubuntu-20.04The
ubuntu-latestlabel points to the latest stable release, which is currently Ubuntu 24.04. Therefore, specifyingruns-on: ubuntu-latestin your workflow will use theubuntu-24.04runner. (docs.github.com)To use a specific version, you can set the
runs-onattribute to the desired label. For example:jobs: build: runs-on: ubuntu-24.04 steps: - uses: actions/checkout@v4 - name: Set up Node.js uses: actions/setup-node@v4 with: node-version: '14' - run: npm install - run: npm testThis configuration ensures that your job runs on the Ubuntu 24.04 runner. (docs.github.com)
For more details on choosing the appropriate runner for your job, refer to the GitHub documentation on Choosing the runner for a job.
Citations:
- 1: https://docs.github.com/en/actions/writing-workflows/choosing-where-your-workflow-runs/choosing-the-runner-for-a-job?utm_source=openai
- 2: https://docs.github.com/en/actions/writing-workflows/choosing-where-your-workflow-runs/choosing-the-runner-for-a-job?utm_source=openai
Ignore outdated runner warning:
ubuntu-24.04is supported
According to GitHub’s documentation (June 2025), the available Ubuntu runner labels includeubuntu-24.04. No change is needed—the workflow’sruns-on: ubuntu-24.04will succeed.Likely an incorrect or invalid review comment.
.github/workflows/cmake.yml (1)
27-29: Approved: Add Windows Server 2022 + VS2022 to the matrix
Usingvs2022onwindows-2022aligns with the updated CI environments and matches GitHub’s supported runner labels. No issues detected.
|
As we don't test ACE/TAO anymore on CI with Visual Studio 2019 what about removing the generation of the vs2019 solutions from the release, only ship with vs2022? |
Seems like that's a discussion for the ACE_TAO repository, it shouldn't make a difference to the MPC repository. |
Summary by CodeRabbit