-
Notifications
You must be signed in to change notification settings - Fork 63
Early support of the Saigo toolchain #981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dd72e1a
to
dbb5697
Compare
sgame statusCurrently the sgame builds and links for all architectures. I have tested the amd64 sgame and it runs. cgame statusThe cgame builds for all architectures but the final linkage fails. To fix this we may build freetype, libpng and lua with Saigo (PNaCl provided a pexe It is believed this is the last thing required to achieve cgame building with Saigo. |
7144715
to
61b44c2
Compare
At first I hoped this was for building the NaCl libc. 🥲️ |
61b44c2
to
4e5b48c
Compare
fca5c0f
to
4f754ac
Compare
More should be done later. The cgame still doesn't build because we would also need to build some dependencies like zlib with Saigo, but the current status is good enough to be merged and avoid piling merge conflicts with it in the future. |
@@ -335,8 +337,10 @@ static void CrashHandler(const void* data, size_t n) | |||
|
|||
void SetupCrashHandler() | |||
{ | |||
#if !defined(__saigo__) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this removed? It's the only debugging mechanism we have for NaCl.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably because I didn't make it work.
I think we should be able to avoid zlib by adjusting the Freetype configuration. zlib is only depended on from functions concerning gzip support. Don't think that's something we need but I could be wrong |
9064efe
to
b05ea3c
Compare
I can build with Saigo freetype without libpng and without zlib in cgame and get it run properly. |
So, this looks ready to me, it is known to be able to build a full game (cgame+sgame) that runs once other PRs taking care of other topic are merged. So these two PRs centered on the toolchain itself are good. Improvements, like investigating and possibly re-enabling |
sgame statusThe sgame builds and links for all architectures. I have tested the amd64 sgame and it runs. cgame statusThe cgame builds and links for all architectures. I have tested the amd64 cgame and it runs. The cgame also requires this to build: |
b05ea3c
to
8fe1b18
Compare
3c91fa0
to
2faaeba
Compare
LGTM |
2faaeba
to
80e8006
Compare
Continuing the work done in:
How to use
Use this game branch too:
Get the Saigo toolchain, see:
Symlink the
native_client/toolchain/linux_x86/saigo_newlib
folder intoexternal_deps/linux-amd64-default_10
.Then do:
Current status