Skip to content

Append .exe to fix helper lookup in win #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2020
Merged

Append .exe to fix helper lookup in win #117

merged 1 commit into from
May 20, 2020

Conversation

jneira
Copy link
Collaborator

@jneira jneira commented May 14, 2020

Now i get

using helper compiled with Cabal from v2-build package-env C:\Users\atrey\Local Settings\Cache\cabal-helper\ghc-8.8.3.package-envs\Cabal-3.2.0.0.package-env
helper already compiled, using exe: C:\Users\atrey\Local Settings\Cache\cabal-helper\cabal-helper-1.1.0.0--Cabal-3.2.0.0--642c18efd5657699c4a87dbd7ad05e3be3857a9df0526a676bd8d0a5fcce9476.build\cabal-helper.exe
compileHelper took 0.69509s

@jneira jneira requested a review from DanielG May 14, 2020 22:14
DanielG
DanielG requested changes May 15, 2020
View reviewed changes
@jneira
Copy link
Collaborator Author

jneira commented May 15, 2020 •
edited
Loading

@DanielG done! thanks for review, it is better to fix it in the constructor

@jneira jneira requested a review from DanielG May 19, 2020 06:09
jneira added a commit to jneira/haskell-language-server that referenced this pull request May 19, 2020
@jneira
Use cabal-helper patched version for win
8c56175 
That version has a fix to avoid recompiling the cabal-helper
executable in windows
See DanielG/cabal-helper#117
DanielG
DanielG approved these changes May 20, 2020
View reviewed changes
Copy link
Owner

@DanielG DanielG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@DanielG DanielG merged commit 8b51b51 into DanielG:master May 20, 2020
@jneira jneira deleted the fix-exe-lookup branch May 25, 2020 19:34
@jneira jneira mentioned this pull request May 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielG DanielG DanielG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jneira @DanielG